Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--field-selector option isn't applied for the retry and resubmit archive commands #13223

Open
4 tasks done
yevgeny-z opened this issue Jun 20, 2024 · 0 comments · May be fixed by #13224
Open
4 tasks done

--field-selector option isn't applied for the retry and resubmit archive commands #13223

yevgeny-z opened this issue Jun 20, 2024 · 0 comments · May be fixed by #13224
Labels
area/cli The `argo` CLI type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@yevgeny-z
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

Field-selector option isn't applied for the retry and resubmit archive commands

Retry and resubmit archive commands use field-selector option as namespace.
This bug created in #10399 PR when FieldSelector was removed and namespace is added to listArchivedWorkflows function.

I suggest to restore this option for function and add support of field-selector for list command

Version

v3.5.7

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

$ argo -n <namespace> archive retry --field-selector metadata.name=<workflow name> --restart-successful --node-field-selector displayName=<step-name> -v
DEBU[2024-06-19T18:39:49.936Z] CLI version version="{v3.5.7+503eef1.dirty 2024-05-27T06:30:29Z 503eef1357ebc9facc3f463708031441072ef7c2 v3.5.7 dirty go1.22.3 gc darwin/arm64}"
DEBU[2024-06-19T18:39:49.936Z] Client options opts="(argoServerOpts=(url=argo-workflows.<domain>:443,path=,secure=true,insecureSkipVerify=false,http=true),instanceID=)"
DEBU[2024-06-19T18:39:49.936Z]  listOpts="&ListOptions{LabelSelector:,FieldSelector:,Watch:false,ResourceVersion:,TimeoutSeconds:nil,Limit:0,Continue:,AllowWatchBookmarks:false,ResourceVersionMatch:,}"
DEBU[2024-06-19T18:39:49.937Z] curl -X GET -H 'Authorization: ******' -d '' 'https://argo-workflows.<domain>:443/api/v1/archived-workflows?namespace=metadata.name%3D<workflow name>'

Logs from the workflow controller

none, it's cli issue

Logs from in your workflow's wait container

none, it's cli issue
@agilgur5 agilgur5 added type/regression Regression from previous behavior (a specific type of bug) area/cli The `argo` CLI labels Jun 20, 2024
@agilgur5 agilgur5 changed the title field-selector option isn't applied for the retry and resubmit archive commands --field-selector option isn't applied for the retry and resubmit archive commands Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli The `argo` CLI type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants