Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checksum/config to automagically roll deployments on ConfigMap Changes #12876

Closed
ak-a opened this issue Apr 3, 2024 · 2 comments
Closed
Labels
area/controller Controller issues, panics area/downstream This is an issue downstream (e.g. Helm Charts, KFP, Metaflow, etc), and not with Argo itself area/manifests solution/invalid This is incorrect. Also can be used for spam solution/workaround There's a workaround, might not be great, but exists type/feature Feature request

Comments

@ak-a
Copy link

ak-a commented Apr 3, 2024

Make Argo Workflows Deployment Restart on Config change

Add an annotation to the Argo Workflows helm chart as documented:
https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

Use Cases

Deploying Argo Workflows using Argo CD would then automatically restart the Deployment as the deployment changes if the Config changes. Simpler than having a ConfigMap watch which is buggy on some Kubernetes versions and has an overhead on the cluster.


Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

@ak-a ak-a added the type/feature Feature request label Apr 3, 2024
@agilgur5 agilgur5 added area/controller Controller issues, panics area/manifests type/support User support issue - likely not a bug and removed type/feature Feature request labels Apr 3, 2024
@agilgur5
Copy link
Member

agilgur5 commented Apr 3, 2024

Add an annotation to the Argo Workflows helm chart

There are no Helm Charts in this repo. Not sure if you meant to post this in https://github.com/argoproj/argo-helm?

automatically restart the Deployment as the deployment changes if the Config changes. Simpler than having a ConfigMap watch

It is simpler and you can certainly use that as a workaround. It is recommended for the Server even as it has no hot reloading feature yet: #10970.

However the Controller ConfigMap watch feature is different from this. It changes the configuration in-memory without needing a restart (or rolling deploy).

As such, if it were to be added to argo-helm, the feature should be optional, as the Controller already has a built-in feature for that that does not require a restart.

a ConfigMap watch which is buggy on some Kubernetes versions

It sounds like you're referring to #11657, which is slated to be fixed soon.

@ak-a
Copy link
Author

ak-a commented Apr 4, 2024

Thanks @agilgur5 - I have raised the issue in the helm repo. I am hoping to find time to contribute a possible patch myself.

@agilgur5 agilgur5 added the area/downstream This is an issue downstream (e.g. Helm Charts, KFP, Metaflow, etc), and not with Argo itself label May 30, 2024
@agilgur5 agilgur5 added type/feature Feature request solution/invalid This is incorrect. Also can be used for spam and removed type/support User support issue - likely not a bug labels Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/downstream This is an issue downstream (e.g. Helm Charts, KFP, Metaflow, etc), and not with Argo itself area/manifests solution/invalid This is incorrect. Also can be used for spam solution/workaround There's a workaround, might not be great, but exists type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants