Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a PVC as log temporary folder #12661

Open
e-tip opened this issue Feb 13, 2024 · 2 comments
Open

Allow to specify a PVC as log temporary folder #12661

e-tip opened this issue Feb 13, 2024 · 2 comments
Labels
area/archive-logs Archive Logs feature area/artifacts S3/GCP/OSS/Git/HDFS etc area/executor area/spec Changes to the workflow specification. solution/workaround There's a workaround, might not be great, but exists type/feature Feature request

Comments

@e-tip
Copy link

e-tip commented Feb 13, 2024

Summary

I'd like to have a way to specify a PVC to be mounted into the wait container so the logs output can use this pvc instead of the ephemeral storage. Unfortunately uploading logs to s3 is quite hard if i have to save all the output of a workflow in a single file.
I've used fluentbit with the s3 plugin, but it requires a variable part on the file key in order to be sure to not overwrite the existing data.
I know that it's clear in the documentation that you suggest to not rely on argowf for logs archiving, but if one doesn't need to process the logs but only archive it on s3, it's still the best solution

Use Cases

When an application logs a lot of data and the archiveLogs option is true, argowf relies on the ephemeral-storage of the wait container to save a temporary file, which leads, if a worker node has little disk space, to be filled up. To prevent this we can set the resource limit on the wait-container, but this makes the pod to fail if the log is bigger than the limit.
To be able to use the archiveLog option without worrying too much of the disk space, setting the tmp location to a PVC could be a good idea


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.

@e-tip e-tip added the type/feature Feature request label Feb 13, 2024
@agilgur5 agilgur5 added area/spec Changes to the workflow specification. area/archive-logs Archive Logs feature labels Feb 13, 2024
@agilgur5
Copy link
Member

agilgur5 commented Feb 13, 2024

For reference, Slack thread about this.

You can use podSpecPatch to modify the wait container and add a volume

@agilgur5 agilgur5 added solution/workaround There's a workaround, might not be great, but exists area/executor labels Feb 13, 2024
@e-tip
Copy link
Author

e-tip commented Feb 13, 2024

i tried, but in this way i can't use the volumeClaimTemplates, but i need to use an existing PVC, right ? And in case of a DAG workflow with a withItems, pods should overwrite the log each other

@agilgur5 agilgur5 added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/archive-logs Archive Logs feature area/artifacts S3/GCP/OSS/Git/HDFS etc area/executor area/spec Changes to the workflow specification. solution/workaround There's a workaround, might not be great, but exists type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants