Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Complex schedule expression in CronWorkflow #12493

Closed
t-arata opened this issue Jan 9, 2024 · 2 comments · Fixed by #12616
Closed

Support Complex schedule expression in CronWorkflow #12493

t-arata opened this issue Jan 9, 2024 · 2 comments · Fixed by #12616
Labels
area/controller Controller issues, panics area/cron-workflows type/feature Feature request
Milestone

Comments

@t-arata
Copy link

t-arata commented Jan 9, 2024

Summary

Improve CronWorkflow to support multiple complex cron schedules.

What change needs making?

Currently, a single CronWorkflow can only be configured with a single cron expression. This makes it hard to configure complex schedules that can't be expressed with a single cron expression. To resolve this, I suggest that we improve CronWorkflow to allow the usage of multiple cron expressions in a single CronWorkflow resource.

Use Cases:

I have a script that I need to run on a complex schedule, which isn't expressible with a single cron expression. The schedule changes within the day, week, and month as follows:

0  11    *  *  1-5 /path/to/some_process
20 11-13 *  *  1-5 /path/to/some_process
50 11-18 21 09 *   /path/to/some_process
50 11-18 24 10 *   /path/to/some_process

With the current implementation, I'd need to create a separate CronWorkflow for each schedule. It comes with some inconveniences: having to manage multiple CronWorkflows and the possibility of the script executed by different CronWorkflows at the same time, causing overlapping execution.

By allowing a single CronWorkflow to take multiple cron expressions, it will ease the management of schedules and ensure that the same script is not run by different CronWorkflows simultaneously.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.

@t-arata t-arata added the type/feature Feature request label Jan 9, 2024
@Joibel Joibel added area/controller Controller issues, panics area/cron-workflows labels Jan 9, 2024
@eduardodbr
Copy link
Member

Probably duplicate of #9734, #8348, #8347

@skewer35

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/cron-workflows type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants