BUG: Any retry makes dag fail

[xubofei1983]

Is this a BUG REPORT or FEATURE REQUEST?:
BUG REPORT

What happened:
In a dag workflow, any step fail and retry make the dag workflow fail, even workflow succeeded.

What you expected to happen:
It should not fail.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Argo version:

in current master branch
8aae29317a8cfef2edc084a4c74a44c83d845936

• Kubernetes version :

$ kubectl version -o yaml

clientVersion:
  buildDate: 2018-08-08T16:31:10Z
  compiler: gc
  gitCommit: bb9ffb1654d4a729bb4cec18ff088eacc153c239
  gitTreeState: clean
  gitVersion: v1.11.2
  goVersion: go1.10.3
  major: "1"
  minor: "11"
  platform: darwin/amd64
serverVersion:
  buildDate: 2018-12-04T13:33:10Z
  compiler: gc
  gitCommit: 6bf27214b7e3e1e47dce27dcbd73ee1b27adadd0
  gitTreeState: clean
  gitVersion: v1.10.11-eks
  goVersion: go1.9.3
  major: "1"
  minor: 10+
  platform: linux/amd64

Other debugging information (if applicable):

• workflow result:

$ argo get <workflowname>

   argo get retry-with-dags-cnxlf
Name:                retry-with-dags-cnxlf
Namespace:           workflow
ServiceAccount:      default
Status:              Failed
Created:             Thu Feb 14 15:29:05 -0800 (5 minutes ago)
Started:             Thu Feb 14 15:29:05 -0800 (5 minutes ago)
Finished:            Thu Feb 14 15:29:10 -0800 (5 minutes ago)
Duration:            5 seconds

STEP                      PODNAME                           DURATION  MESSAGE
 ✖ retry-with-dags-cnxlf
 ├-✔ hello1(0)            retry-with-dags-cnxlf-2137718726  1s
 ├-✔ hello2(0)            retry-with-dags-cnxlf-1642480525  1s
 └-✔ hello3
   ├-✖ hello3(0)          retry-with-dags-cnxlf-612471880   1s        failed with exit code 1
   └-✔ hello3(1)          retry-with-dags-cnxlf-813656213   2s

• executor logs:

• workflow-controller logs:

[xubofei1983]

@alexmt, I think it is introduced recently. This is critical bug.

step workflow is fine. only impact dag workflow.

Should be easily reproduce with
https://gist.github.com/xubofei1983/63a057f0d8ef90b6e14ed93e09ba5b98

[alexmt]

Sorry, working on fix.

[alexmt]

Issue was fixed by #1221 . Thanks to @houz42 !