Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid successful nodes in Steps being re-executed via retryStrategy #12009

Open
jswxstw opened this issue Oct 16, 2023 · 1 comment
Open

Avoid successful nodes in Steps being re-executed via retryStrategy #12009

jswxstw opened this issue Oct 16, 2023 · 1 comment
Labels
area/retryStrategy Template-level retryStrategy type/feature Feature request

Comments

@jswxstw
Copy link
Member

jswxstw commented Oct 16, 2023

Summary

Successful nodes should not be re-executed when Steps(has RetryStrategy configured) are retrying

Use Cases

My workflow may use multiple Steps template, but If I configure a RetryStrategy to Steps, nodes in Steps would be re-executed each time it retries.

Howerver, node in Steps may not be idempotent, so it will bring a lot of consistency problems.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@jswxstw jswxstw added the type/feature Feature request label Oct 16, 2023
@jswxstw
Copy link
Member Author

jswxstw commented Oct 16, 2023

image

As the picture shows, Workflow root is a Retry Node and its child nodes are Steps(retried three times), node(create-pvc) was re-executed each time even if it has been executed successfully which may be unaccecptable.

@agilgur5 agilgur5 added the area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries label Oct 16, 2023
@agilgur5 agilgur5 added area/retryStrategy Template-level retryStrategy and removed area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries labels Apr 25, 2024
@agilgur5 agilgur5 changed the title Avoid successful nodes in Steps(has RetryStrategy configured) being re-executed Avoid successful nodes in Steps being re-executed via retryStrategy Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/retryStrategy Template-level retryStrategy type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants