-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting a workflow on the workflow details page doesn't do anything #11661
Comments
cc @toyamagu-2021 This might be related to your fix |
If you refresh, would it be gone? |
I cannot reproduce this both on master branch and on 3.5.0-rc1 on k3d cluster... 🤔 argo-workflows/ui/src/app/workflows/components/workflow-details/workflow-details.tsx Line 203 in 7cb22a2
|
Check developer console and server logs? |
Could you give me your workflow metadata.labels? argo-workflows/ui/src/app/workflows/components/workflow-details/workflow-details.tsx Lines 194 to 195 in 7cb22a2
Or please give me your workflow (might be meaningless...). |
|
The same issue happens with a basic hello world though:
|
Any logs from your workflow controller? |
I am not able to reproduce this either. Please check controller logs to see if the workflow deletion request is handled successfully. |
Interesting. I see some small error on provided gif when entering to the workflow as below. And refer to this specific line in useEffect, are there any chances that |
@shmruin Can you check if your controller/executor/server image versions match? |
Also sent #11676. I suspect there are some errors that appear in the UI for a moment before redirecting to the workflow list page. |
@terrytangyuan Sadly, that screenshot is @tico24 's, and I also fail to reproduce this error. |
@tico24 Can you try the latest image? So far looks like no one else has been able to reproduce your original issue. |
@tico24 Can you check workflow controller and K8s API server logs? I'd be interested to see if the request has been sent successfully. |
Both server and controller logs say nothing special. What specifically do you want from them? |
@tico24 They would indicate whether the deletion request has been received and processed. Just do a grep from the logs. |
The Network tab of the browser console will also show if the request was sent |
I see what I'd expect to see. server:
controller still has nothing. |
Yep exactly what we needed to see. The request went through but was canceled in argo-server. @agilgur5 Looking forward to your fix :-) |
So I too was unable to reproduce this locally. That being said, as I mentioned on Slack, if my hypothesis is correct, then this is a race condition. Specifically, higher latency (as with a remote server vs. local server) may make this more likely. The low latency of local dev may mean that the request completes shortly before or after the page reload and so is not affected by the connection drop. I also did try using throttling in browser dev tools, but that did not reproduce either. That being said, I'm not entirely sure how the emulation works under-the-hood and a slow request/response is not entirely the same as network hops to a remote server. Server-side throttling (e.g. a sleep on the request) may be a bit closer to the real thing, but also a bit different. Forgot to try a server-side throttle though. Wrote up #11711 which hopefully fixes this -- if my hypothesis is correct. |
Pre-requisites
:latest
What happened/what you expected to happen?
If you go to the workflows details page and hit delete (and then confirm the delete), you are taken back to the workflows list page... where your workflow is still sat there staring at you :)
We do not have workflows archiving enabled.
Version
v3.5.0-rc1
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
any workflow
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: