Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude specific dates to not run workflow on (ex. holidays/non-working days). #10296

Open
steffenneyt opened this issue Jan 2, 2023 · 5 comments
Labels
type/feature Feature request

Comments

@steffenneyt
Copy link

Summary

Functionality to not run workflow(s) on certain dates. Like the holiday feature that SOS Berlin's jobscheduler has.

Use Cases

For example when you or your company has fixed holidays/non-working days when you do not want certain workflow(s) to run.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@steffenneyt steffenneyt added the type/feature Feature request label Jan 2, 2023
@nihar-13
Copy link

+1 on this feature.

BTW, it is available in Argo Events - not in workflows.
Its a good thing to have to be able to compete with schedulers in market.

@tooptoop4
Copy link
Contributor

dupe of #8347

@agilgur5 agilgur5 changed the title Add functionality to exclude specific dates to not run workflow on (ex. holidays/non-working days). Exclude specific dates to not run workflow on (ex. holidays/non-working days). Oct 18, 2024
@agilgur5
Copy link
Member

agilgur5 commented Oct 18, 2024

dupe of #8347

That issue is specific to CronWorkflows -- I'm actually unsure if this one was intended to be for CronWorkflows as it doesn't say, or if it was instead intended to be for all Workflows controller-wide, such as #7868 but for any Workflows.

It's probably the former, but not sure.

Also for CronWorkflows for specific dates without a specific calendar as #8347 explicitly says, when of #13474 makes that possible now

@nihar-13
Copy link

nihar-13 commented Oct 18, 2024

Most of the times, workflows are triggered by an external event or trigger. Hence adding specific calendar-checks don't make much sense there. If there are such cases, those are covered by "when clause". Do you think we can add "when" to Workflows?

For CronWorkflows, which are set-once-and-forget, having date-based configurations make more sense. Having explicit parameters to store actual holiday dates (example: 20240101, 20241225, 20250101, 20251225, etc.) gives a more "scheduler-like" feeling. But sourcing it from any external "config-map" should also be equally good, if its latest value can be referred before each execution of cron workflow schedule.

@agilgur5
Copy link
Member

Do you think we can add "when" to Workflows?

That's existed for many years: https://argo-workflows.readthedocs.io/en/release-3.5/walk-through/conditionals/. The new CronWorkflows one is based on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants