Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaults for CronWorkflow? #10254

Closed
max-sixty opened this issue Dec 18, 2022 · 2 comments
Closed

Defaults for CronWorkflow? #10254

max-sixty opened this issue Dec 18, 2022 · 2 comments
Labels
area/controller Controller issues, panics area/cron-workflows solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) solution/workaround There's a workaround, might not be great, but exists type/feature Feature request

Comments

@max-sixty
Copy link
Contributor

Summary

Currently there's a workflowDefaults feature in the worflow controller configmap — very useful!

We'd like to set a default startingDeadlineSeconds, so if the workflow controller fails, it'll create any workflows that it missed when K8s starts another back up. This exists on CronWorkflowSpec rather than WorkflowSpec, though.

Is that possible at the moment?

Thank you!

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@max-sixty max-sixty added the type/feature Feature request label Dec 18, 2022
@matanlb
Copy link

matanlb commented Jan 17, 2024

+1 on this one.
In our use case we'd like to set a default value for concurrencyPolicy (different from argo's default one) so something cronWorkflowDefaults would be useful

@agilgur5 agilgur5 changed the title Is it possible to have defaults for CronWorkflow? Defaults for CronWorkflow? Oct 16, 2024
@agilgur5 agilgur5 added solution/workaround There's a workaround, might not be great, but exists area/controller Controller issues, panics labels Oct 16, 2024
@agilgur5
Copy link
Member

Superseded by #12627 which has more details and upvotes

@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Oct 16, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/controller Controller issues, panics area/cron-workflows solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) solution/workaround There's a workaround, might not be great, but exists type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agilgur5 @max-sixty @matanlb