Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow TTL Strategy based on number of workflows in different phases #10154

Closed
terrytangyuan opened this issue Dec 2, 2022 · 1 comment
Closed
Labels
area/controller Controller issues, panics area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more type/support User support issue - likely not a bug

Comments

@terrytangyuan
Copy link
Member

terrytangyuan commented Dec 2, 2022

Summary

What change needs making?

The current TTL strategy is time-based to delete workflows after x/y/z seconds of success/failure/completion.

Alternatively, we can support only deleting a subset of the workflows. For example, only keep a maximum of x/y/z number of succeeded/failed/completed workflows. All remaining completed workflows are deleted.

Use Cases

When would you use this?

Some users want to keep a number of workflows in each phase for analysis or debugging purposes. It's also easier to see a list of current running workflows + history of the failed/successful ones in one page.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@terrytangyuan terrytangyuan added the type/feature Feature request label Dec 2, 2022
@agilgur5
Copy link
Member

agilgur5 commented Oct 18, 2024

Alternatively, we can support only deleting a subset of the workflows. For example, only keep a maximum of x/y/z number of succeeded/failed/completed workflows. All remaining completed workflows are deleted.

This was/is possible already with retentionPolicy as of #6854.
Notably, that wasn't documented at all until #11297, and could still use a reference in the Cost Optimization page

@agilgur5 agilgur5 added area/controller Controller issues, panics area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more type/support User support issue - likely not a bug and removed type/feature Feature request labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more type/support User support issue - likely not a bug
Projects
None yet
Development

No branches or pull requests

2 participants