From d2c3b36ee131b26910bd63da7aeedcbc29e4b533 Mon Sep 17 00:00:00 2001
From: Anton Gilgur <agilgur5@gmail.com>
Date: Tue, 10 Oct 2023 16:22:57 -0400
Subject: [PATCH] build: fix `ARGO_LOG_LEVEL` -> `ARGO_LOGLEVEL`

- credit to Julie and Alex for debugging this, I merely confirmed the issue and fixed it

- the flag is [`loglevel`](https://github.com/argoproj/argo-workflows/blob/a45afc0c87b0ffa52a110c753b97d48f06cdf166/cmd/workflow-controller/main.go#L54) and with the [automatic env prefix](https://github.com/argoproj/argo-workflows/blob/a45afc0c87b0ffa52a110c753b97d48f06cdf166/cmd/workflow-controller/main.go#L195), that becomes `ARGO_LOGLEVEL` as an env var
  - `ARGO_LOG_LEVEL` was a misconfiguration / typo as such

- also add `watch` list for the `ui-deps` task after my dive into `task`
  - it seemed like `kit` kept re-installing deps when this was missing
---
 Makefile   |  2 +-
 tasks.yaml | 11 ++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 40da27f2e8e8..e1a93a2fbed7 100644
--- a/Makefile
+++ b/Makefile
@@ -558,7 +558,7 @@ endif
 	grep '127.0.0.1.*postgres' /etc/hosts
 	grep '127.0.0.1.*mysql' /etc/hosts
 ifeq ($(RUN_MODE),local)
-	env DEFAULT_REQUEUE_TIME=$(DEFAULT_REQUEUE_TIME) ARGO_SECURE=$(SECURE) ALWAYS_OFFLOAD_NODE_STATUS=$(ALWAYS_OFFLOAD_NODE_STATUS) ARGO_LOG_LEVEL=$(LOG_LEVEL) UPPERIO_DB_DEBUG=$(UPPERIO_DB_DEBUG) ARGO_AUTH_MODE=$(AUTH_MODE) ARGO_NAMESPACED=$(NAMESPACED) ARGO_NAMESPACE=$(KUBE_NAMESPACE) ARGO_MANAGED_NAMESPACE=$(MANAGED_NAMESPACE) ARGO_EXECUTOR_PLUGINS=$(PLUGINS) PROFILE=$(PROFILE) kit $(TASKS)
+	env DEFAULT_REQUEUE_TIME=$(DEFAULT_REQUEUE_TIME) ARGO_SECURE=$(SECURE) ALWAYS_OFFLOAD_NODE_STATUS=$(ALWAYS_OFFLOAD_NODE_STATUS) ARGO_LOGLEVEL=$(LOG_LEVEL) UPPERIO_DB_DEBUG=$(UPPERIO_DB_DEBUG) ARGO_AUTH_MODE=$(AUTH_MODE) ARGO_NAMESPACED=$(NAMESPACED) ARGO_NAMESPACE=$(KUBE_NAMESPACE) ARGO_MANAGED_NAMESPACE=$(MANAGED_NAMESPACE) ARGO_EXECUTOR_PLUGINS=$(PLUGINS) PROFILE=$(PROFILE) kit $(TASKS)
 endif
 
 .PHONY: wait
diff --git a/tasks.yaml b/tasks.yaml
index 5df2a78c74a8..46fd8446efe5 100644
--- a/tasks.yaml
+++ b/tasks.yaml
@@ -4,14 +4,14 @@ metadata:
   annotations:
     help: |
       Install `kit` by following https://github.com/kitproj/kit#install.
-      
+
       Run `kit up` to start argo.
 
       - `env PROFILE=mysql kit up` to start with MySQL.
       - `env PROFILE=plugins ARGO_EXECUTOR_PLUGINS=true kit up` to start with plugins.
       - `env PROFILE=sso ARGO_AUTH_MODE=sso kit up` to start with SSO.
-      
-      The app will be up-and-running between 15s and 1m later (if hot compiled or cold). 
+
+      The app will be up-and-running between 15s and 1m later (if hot compiled or cold).
       Any changes made to the source code will be automatically recompiled and the app restarted, typically within a few seconds.
   name: argo-workflows
 spec:
@@ -43,7 +43,7 @@ spec:
         - ARGO_NAMESPACE=argo
         - ARGO_NAMESPACED=true
         - ARGO_MANAGED_NAMESPACE=argo
-        - ARGO_LOG_LEVEL=info
+        - ARGO_LOGLEVEL=info
         - ARGO_REMOVE_PVC_PROTECTION_FINALIZER=true
         - ARGO_PROGRESS_PATCH_TICK_DURATION=7s
         - DEFAULT_REQUEUE_TIME=1s
@@ -69,7 +69,7 @@ spec:
         - ARGO_SECURE=false
         - ARGO_NAMESPACE=argo
         - ARGO_NAMESPACED=true
-        - ARGO_LOG_LEVEL=info
+        - ARGO_LOGLEVEL=info
         - ARGO_AUTH_MODE=hybrid
         - ARGO_MANAGED_NAMESPACE=argo
         - UPPERIO_DB_DEBUG=1
@@ -77,6 +77,7 @@ spec:
     - name: ui-deps
       command: yarn install
       workingDir: ui
+      watch: ui/package.json ui/yarn.lock
       mutex: downloads
     - name: ui
       command: yarn start