From 8aae29317a8cfef2edc084a4c74a44c83d845936 Mon Sep 17 00:00:00 2001 From: Alexander Matyushentsev Date: Wed, 13 Feb 2019 08:44:37 -0800 Subject: [PATCH] Issue #1190 - Fix incorrect retry node handling (#1208) --- workflow/controller/dag.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/workflow/controller/dag.go b/workflow/controller/dag.go index 1f5601830751..420cf30b3999 100644 --- a/workflow/controller/dag.go +++ b/workflow/controller/dag.go @@ -106,6 +106,10 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes map[string]wfv1. } func hasMoreRetries(node *wfv1.NodeStatus, wf *wfv1.Workflow) bool { + if node.Phase == wfv1.NodeSucceeded { + return false + } + if len(node.Children) == 0 { return true }