From 3b6c53af00843a17dc2f030e08dec1b1c070e3f2 Mon Sep 17 00:00:00 2001 From: Alex Collins Date: Wed, 31 Mar 2021 16:57:47 -0700 Subject: [PATCH] fix(executor): GODEBUG=x509ignoreCN=0 (#5562) Signed-off-by: Alex Collins --- workflow/controller/workflowpod.go | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/workflow/controller/workflowpod.go b/workflow/controller/workflowpod.go index eb7153d1de23..0a0eda014d1b 100644 --- a/workflow/controller/workflowpod.go +++ b/workflow/controller/workflowpod.go @@ -479,16 +479,25 @@ func containerIsPrivileged(ctr *apiv1.Container) bool { } func (woc *wfOperationCtx) createEnvVars() []apiv1.EnvVar { - var execEnvVars []apiv1.EnvVar - execEnvVars = append(execEnvVars, apiv1.EnvVar{ - Name: common.EnvVarPodName, - ValueFrom: &apiv1.EnvVarSource{ - FieldRef: &apiv1.ObjectFieldSelector{ - APIVersion: "v1", - FieldPath: "metadata.name", + execEnvVars := []apiv1.EnvVar{ + { + Name: common.EnvVarPodName, + ValueFrom: &apiv1.EnvVarSource{ + FieldRef: &apiv1.ObjectFieldSelector{ + APIVersion: "v1", + FieldPath: "metadata.name", + }, }, }, - }) + { + // This flag was introduced in Go 15 and will be removed in Go 16. + // x509: cannot validate certificate for ... because it doesn't contain any IP SANs + // https://github.com/argoproj/argo-workflows/issues/5563 - Upgrade to Go 16 + // https://github.com/golang/go/issues/39568 + Name: "GODEBUG", + Value: "x509ignoreCN=0", + }, + } if woc.controller.Config.Executor != nil { execEnvVars = append(execEnvVars, woc.controller.Config.Executor.Env...) }