From 0978c4d62fc0bb415fa93e9ba924e54358f72334 Mon Sep 17 00:00:00 2001 From: Goober Date: Fri, 13 Oct 2023 22:33:49 +0800 Subject: [PATCH] fix test case for fastFail Signed-off-by: Goober --- workflow/controller/dag_test.go | 6 +++--- workflow/controller/exit_handler_test.go | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/workflow/controller/dag_test.go b/workflow/controller/dag_test.go index fd8e0f6b2b58..82f3e0875950 100644 --- a/workflow/controller/dag_test.go +++ b/workflow/controller/dag_test.go @@ -1689,7 +1689,7 @@ func TestRetryStrategyNodes(t *testing.T) { assert.Equal(t, wfv1.NodePending, onExitNode.Phase) } - assert.Equal(t, wfv1.WorkflowRunning, woc.wf.Status.Phase) + assert.Equal(t, wfv1.WorkflowCanceled, woc.wf.Status.Phase) } var testOnExitNodeDAGPhase = ` @@ -1847,7 +1847,7 @@ func TestOnExitDAGPhase(t *testing.T) { retryNode, err := woc.wf.GetNodeByName("dag-diamond-88trp") if assert.NoError(t, err) { assert.NotNil(t, retryNode) - assert.Equal(t, wfv1.NodeRunning, retryNode.Phase) + assert.Equal(t, wfv1.NodeSucceeded, retryNode.Phase) } retryNode, err = woc.wf.GetNodeByName("dag-diamond-88trp.B.onExit") @@ -1856,7 +1856,7 @@ func TestOnExitDAGPhase(t *testing.T) { assert.Equal(t, wfv1.NodePending, retryNode.Phase) } - assert.Equal(t, wfv1.WorkflowRunning, woc.wf.Status.Phase) + assert.Equal(t, wfv1.WorkflowSucceeded, woc.wf.Status.Phase) } var testOnExitNonLeaf = ` diff --git a/workflow/controller/exit_handler_test.go b/workflow/controller/exit_handler_test.go index 1a10001cf697..f16adbf6fd3c 100644 --- a/workflow/controller/exit_handler_test.go +++ b/workflow/controller/exit_handler_test.go @@ -491,7 +491,7 @@ func TestDAGOnExit(t *testing.T) { } woc3 := newWorkflowOperationCtx(woc2.wf, controller) woc3.operate(ctx) - assert.Equal(t, wfv1.WorkflowRunning, woc3.wf.Status.Phase) + assert.Equal(t, wfv1.WorkflowSucceeded, woc3.wf.Status.Phase) onExitNodeIsPresent = false for _, node := range woc3.wf.Status.Nodes { if node.Phase == wfv1.NodePending && strings.Contains(node.Name, "onExit") { @@ -997,5 +997,5 @@ status: assert.Len(t, taskSets.Items, 0) } woc.operate(ctx) - assert.Equal(t, woc.wf.Status.Phase, wfv1.WorkflowRunning) + assert.Equal(t, wfv1.WorkflowSucceeded, woc.wf.Status.Phase) }