fix: create analysisrun cmd using template generated name #1471
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
+ Coverage 81.35% 81.49% +0.14%
==========================================
Files 108 108
Lines 14505 14518 +13
==========================================
+ Hits 11801 11832 +31
+ Misses 2089 2058 -31
- Partials 615 628 +13
Continue to review full report at Codecov.
|
- set templateName if analsysis template has name in metadata - add unit test Signed-off-by: Hui Kang <hui.kang@salesforce.com>
huikang
force-pushed
the
fix-cmd-analyaisrun-create-name
branch
2 times, most recently
from
4082dbe
to
ceb8e09
Compare
- unit test Signed-off-by: Hui Kang <hui.kang@salesforce.com>
huikang
force-pushed
the
fix-cmd-analyaisrun-create-name
branch
from
ceb8e09
to
90290f6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| objName, notFound, err := unstructured.NestedString(obj.Object, "metadata", "name") | ||
| objName, found, err := unstructured.NestedString(obj.Object, "metadata", "name") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if !notFound { | ||
| if found { |
| // Remove resourceVersion if exists | ||
| _, found, err := unstructured.NestedString(obj.Object, "metadata", "resourceVersion") |
There was a problem hiding this comment.
Does this fix imply we never had --from in-cluster-analysis-template working properly?
There was a problem hiding this comment.
yeah, the unit test failed to catch that because of the fake client.
jessesuen
changed the title
Signed-off-by: Hui Kang hui.kang@salesforce.com
fix #1473
Checklist:
"fix(controller): Updates such and such. Fixes #1234".