Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconclusive result on Kubernetes Job metric #2250

Open
object88 opened this issue Sep 19, 2022 · 4 comments
Open

Inconclusive result on Kubernetes Job metric #2250

object88 opened this issue Sep 19, 2022 · 4 comments
Labels
analysis Related to Analysis CRD enhancement New feature or request no-issue-activity

Comments

@object88
Copy link

Summary

The current implementation of the Job metric does not allow for an "inconclusive" result. This puts it at a technical deficit against other metrics.

Use Cases

I can think of 2 use cases:

  1. The job is unable to start, as with a CLB or Image Pull Error, as mentioned in Issue 1329
  2. The job successfully starts, but it itself is unable to determine if the results was certainly a success or a failure.

My personal use-case is the second: we have a Job that starts a GHA workflow. In some cases, the workflow simply does not run or complete in time (say, because Github is down, or we have a terrible backlog). I would like to be able to go to an Argo console or CLI and indicate whether the promotion should proceed. For example, maybe I know that my GHA workflow (some particular time) is going to fail due to $REASONS, but I want to ignore that and proceed anyway.

The current implementation only allows me to work in absolutes.

Notes

The framework for an inconclusive result is established for other metrics.

I would propose that if a Job returns JSON, the existing evaluation could be applied.

I would also propose that the Job be augmented with a new property that describes the anticipated reaction if the Job does not start or has a non-zero exit code. The default would be consistent with current behavior (success) so that existing Jobs are not impacted. Non-default values would indicate that the Job was a fail or inconclusive.

This should maybe be two separate proposals?


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@object88 object88 added the enhancement New feature or request label Sep 19, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@Abhishek-Kaudare
Copy link

Is there any updates on this enhancement?

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Related to Analysis CRD enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants