Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-image-updater): add podSecurityPolicy and rbac permission #931

Closed
wants to merge 1 commit into from
Closed

feat(argo-image-updater): add podSecurityPolicy and rbac permission #931

wants to merge 1 commit into from

Conversation

yanehi
Copy link

@yanehi yanehi commented Sep 15, 2021

We have the problem that for image writeback the argocd-image-updater needs to access its rootFS. Our Pods are running unprivileged and not in kube-system namespace, so iam not be able to change readOnlyRootFilesystem in the values.yml to true.

Errors:

time="2021-09-15T14:52:10Z" level=info msg="Processing results: applications=1 images_considered=1 images_skipped=0 images_updated=0 errors=1"
time="2021-09-15T14:52:10Z" level=error msg="Could not update application spec: mkdir /tmp/git-XXXXXXXXXX: read-only file system" application=XXXXX

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: yanehi <nevado-git@magenta.de>
@mkilchhofer
Copy link
Member

IMHO this is the wrong direction to fix this. As far as I understand, this pod only wants to have its own temporary scratch space.
In my opinion we'd better mount an emptyDir volume on /tmp like other argo components use.

@mkilchhofer
Copy link
Member

Can you please retest it with version 0.1.1? I think I resolved it via PR #933

@mkilchhofer mkilchhofer added the more-information-needed Waiting on additional information from issue/PR reporter. label Sep 16, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argocd-image-updater more-information-needed Waiting on additional information from issue/PR reporter. no-pr-activity size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants