Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Add affinity to redisSecretInit Job #2962

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat(argo-cd): Add affinity to redisSecretInit Job #2962

merged 1 commit into from
Oct 3, 2024

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Oct 3, 2024 •
edited
Loading

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@tico24
Copy link
Member

tico24 commented Oct 3, 2024 •
edited
Loading

Thanks for your PR.

If you could please update the title and complete the changelog, then we can get to reviewing.

@jmeridth jmeridth changed the title feat: Add affinity to redisSecretInit Job feat(argo-cd): Add affinity to redisSecretInit Job Oct 3, 2024
@tico24
Copy link
Member

tico24 commented Oct 3, 2024

Or @jmeridth could do it for you just to make me look grumpy...

tico24
tico24 requested changes Oct 3, 2024
View reviewed changes
charts/argo-cd/values.yaml Outdated Show resolved Hide resolved
charts/argo-cd/Chart.yaml Show resolved Hide resolved
@killianmuldoon
feat: Add affinity to redisSecretInit Job
29d3b6a 
Signed-off-by: killianmuldoon <kmuldoon@nvidia.com>
@github-actions github-actions bot added the size/S label Oct 3, 2024
@killianmuldoon
Copy link
Contributor Author

Thanks for the quick review - I believe it should be in line now.

@yu-croco yu-croco merged commit bbb38b3 into argoproj:main Oct 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico24 tico24 tico24 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@killianmuldoon @tico24 @yu-croco