fix(argo-workflows): Add missing workflow permission #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilchhofer
changed the title
engson
requested review from
stefansedich,
vladlosev and
yann-soubeyrand
as code owners
…oj#1242) * Issue 1565: Adding additional RBAC for leader election Signed-off-by: David Collom <david.collom@jetstack.io> * Adding Additional RBAC for Events Signed-off-by: David Collom <david.collom@jetstack.io> * Use consistent indent style Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> * Bump minor chart version and add changelog Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Signed-off-by: Sondre Engen <corastweb94@hotmail.com>
Signed-off-by: Sondre Engen <corastweb94@hotmail.com>
* chore(argo-cd): Document how to upgrade CRDs Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * feat(argo-cd): Update chart version and changelog Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Signed-off-by: Sondre Engen <corastweb94@hotmail.com>
Signed-off-by: Sondre Engen <corastweb94@hotmail.com>
Signed-off-by: Sondre Engen <corastweb94@hotmail.com>
engson
requested review from
jbehling,
VaibhavPage,
davidkarlsen,
mbevc1 and
mkilchhofer
as code owners
davidkarlsen
approved these changes
May 1, 2022
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
* feat(argo-events): Adding additional RBAC for leader election (argoproj#1242) * Issue 1565: Adding additional RBAC for leader election Signed-off-by: David Collom <david.collom@jetstack.io> * Adding Additional RBAC for Events Signed-off-by: David Collom <david.collom@jetstack.io> * Use consistent indent style Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> * Bump minor chart version and add changelog Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Signed-off-by: Sondre Engen <corastweb94@hotmail.com> * Add missing permission to workflow sa Signed-off-by: Sondre Engen <corastweb94@hotmail.com> * chore(argo-cd): Document how to upgrade CRDs (argoproj#1251) * chore(argo-cd): Document how to upgrade CRDs Signed-off-by: Petr Drastil <petr.drastil@gmail.com> * feat(argo-cd): Update chart version and changelog Signed-off-by: Petr Drastil <petr.drastil@gmail.com> Signed-off-by: Sondre Engen <corastweb94@hotmail.com> * Update chart version Signed-off-by: Sondre Engen <corastweb94@hotmail.com> * Added changelog Signed-off-by: Sondre Engen <corastweb94@hotmail.com> Co-authored-by: David Collom <david@collom.co.uk> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Petr Drastil <petr.drastil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix permission issue for argo-workflow v3.3.2
Workflow tasks log from wait container:
User "system:serviceaccount:custom-namespace:custom-workflow-role" cannot create resource "workflowtaskresults" in API group "argoproj.io" in the namespace "custom-namespace"Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.