feat(argo-cd): Add support for argocd-extensions resources #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Luhovtsov <yevhen.luhovtsov@intapp.com>
EugeneLugovtsov
requested review from
davidkarlsen,
mbevc1 and
yann-soubeyrand
as code owners
EugeneLugovtsov
changed the title
mbevc1
reviewed
Dec 11, 2021
charts/argo-cd/values.yaml
Outdated
| @@ -1289,6 +1289,15 @@ server: | |||
| # -- Image pull policy for extensions | |||
| imagePullPolicy: IfNotPresent | |||
|
|
|||
| # -- Resource limits and requests for the argocd-extensions pods | |||
There was a problem hiding this comment.
Suggested change
| # -- Resource limits and requests for the argocd-extensions pods | |
| # -- Resource limits and requests for the argocd-extensions container |
There was a problem hiding this comment.
Fixed. Thank you
charts/argo-cd/README.md
Outdated
| @@ -399,6 +399,7 @@ NAME: my-release | |||
| | server.extensions.image.imagePullPolicy | string | `"IfNotPresent"` | Image pull policy for extensions | | |||
| | server.extensions.image.repository | string | `"ghcr.io/argoproj-labs/argocd-extensions"` | Repository to use for extensions image | | |||
| | server.extensions.image.tag | string | `"v0.1.0"` | Tag to use for extensions image | | |||
| | server.extensions.resources | object | `{}` | Resource limits and requests for the argocd-extensions pods | | |||
There was a problem hiding this comment.
Suggested change
| | server.extensions.resources | object | `{}` | Resource limits and requests for the argocd-extensions pods | | |
| | server.extensions.resources | object | `{}` | Resource limits and requests for the argocd-extensions container | |
Signed-off-by: Yevhen Luhovtsov <yevhen.luhovtsov@intapp.com>
mbevc1
approved these changes
Dec 11, 2021
|
Thanks for your contribution! |
6 tasks
sylus
added a commit
to sylus/argo-helm
that referenced
this pull request
Dec 14, 2021
* master: (49 commits) feat(argo-cd): Add support for argocd-extensions resources (argoproj#1053) feat(argo-cd): Add support for extension (argoproj#1050) feat(argo-rollouts): Allow setting the type for the dashboard service (argoproj#973) feat(argocd-applicationset): Add resources metrics-service and servicemonitor. (argoproj#1041) feat(argocd-image-updater): Mount ssh-known-hosts from argocd (argoproj#1040) feat(argo-workflows): Add dev/delegated auth (argoproj#1048) docs(argo-cd): mention declarative set up for Argo-CD (argoproj#1037) feat(argo-cd): Support for additional labels (argoproj#929) chore(argocd): remove myself from CODEOWNERS (argoproj#1044) feat(argo-cd): support initContainers on all pods (argoproj#1043) bumped appVersion / image to v1.2.0 (argoproj#1039) feat(argocd-image-updater): Update to app version v0.11.0 (argoproj#1036) feat(argo-cd): add flag and labels for application labels (argoproj#1021) fix(argo-workflows): Add missing WorkflowTasksets RBAC to controller (argoproj#1032) chore(argocd): remove myself from CODEOWNERS (argoproj#1029) feat(argo-workflows): Include pod name in key format for GCS logs (argoproj#915) feat(argo-workflows): support resourceRateLimit config (argoproj#1008) feat(argocd-image-updater): Add missing config map key for git commit-message-template (argoproj#986) feat(argo-workflows): Upgrade argo-workflows to v3.2.4 (argoproj#1030) feat(argo-cd): Upgrade argocd to v2.1.7 (argoproj#1024) ...
6 tasks
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Dec 23, 2021
…1053) * add support for extensions resource Signed-off-by: Yevhen Luhovtsov <yevhen.luhovtsov@intapp.com> * fix documentation for extensions resource Signed-off-by: Yevhen Luhovtsov <yevhen.luhovtsov@intapp.com> Co-authored-by: Yevhen Luhovtsov <yevhen.luhovtsov@intapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to set up the argocd-extensions resources.
Signed-off-by: Yevhen Luhovtsov yevhen.luhovtsov@intapp.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.