Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Add support for extension #1050

Merged
merged 12 commits into from
Dec 10, 2021
Merged

feat(argo-cd): Add support for extension #1050

merged 12 commits into from
Dec 10, 2021

Conversation

yq314
Copy link
Contributor

@yq314 yq314 commented Dec 4, 2021 •
edited
Loading

This MR is intended to add support for ArgoCD extension, closes #971

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

@github-actions github-actions bot added the size/L label Dec 4, 2021
@yq314 yq314 changed the title add support for extension feat(argo-cd): Add support for extension Dec 4, 2021
@yq314 yq314 force-pushed the add-extension-support branch 2 times, most recently from be695e9 to 8a23412 Compare December 4, 2021 06:52
add support for extension
feb120a 
Signed-off-by: Qing Ye <ye.qing@gojek.com>
@yq314 yq314 force-pushed the add-extension-support branch from 8a23412 to feb120a Compare December 4, 2021 07:00
add volume mounts
7ae59f5 
Signed-off-by: Qing Ye <ye.qing@gojek.com>
mbevc1
mbevc1 reviewed Dec 4, 2021
View reviewed changes
Copy link
Collaborator

@mbevc1 mbevc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to extend RBAC as well?
https://github.com/argoproj-labs/argocd-extensions/tree/main/manifests/rbac

@mbevc1 mbevc1 added the argo-cd label Dec 4, 2021
add RBAC
0bf042a 
Signed-off-by: Qing Ye <ye.qing@gojek.com>
@yq314
Copy link
Contributor Author

yq314 commented Dec 4, 2021

Do we also need to extend RBAC as well? https://github.com/argoproj-labs/argocd-extensions/tree/main/manifests/rbac

Have added RBAC in the new commit, please take a look

@yq314 yq314 requested a review from mbevc1 December 4, 2021 14:43
@mbevc1
Copy link
Collaborator

mbevc1 commented Dec 4, 2021

Thanks for the contribution, looks good. Small comment on container image label.

Qing Ye and others added 3 commits December 5, 2021 00:05
add missing extensions.enabled
4e5c745 
Signed-off-by: Qing Ye <ye.qing@gojek.com>
mbevc1
mbevc1 approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@mbevc1 mbevc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mbevc1
Copy link
Collaborator

mbevc1 commented Dec 6, 2021

@mkilchhofer @davidkarlsen haven't managed to test this yet (Looks okay), but would appreciate second pair of eyes before merging ;)

mkilchhofer
mkilchhofer reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the version bump I have another small point to discuss:
Would it make sense to mention that this is an early Argoproj subproject? (something like TechPreview or so?)

@yq314
Copy link
Contributor Author

yq314 commented Dec 7, 2021

Beside the version bump I have another small point to discuss: Would it make sense to mention that this is an early Argoproj subproject? (something like TechPreview or so?)

Hi Macro, thanks for the suggestion, I didn't know it is TechPreview actually. Where would be the best place to mention this? In the commend in the values file?

@yq314 @mkilchhofer
Update charts/argo-cd/Chart.yaml
6a7d467 
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Qing Ye <ye.qing@gojek.com>
@yq314 yq314 force-pushed the add-extension-support branch from 4ae0cde to 6a7d467 Compare December 7, 2021 02:51
@yq314
Copy link
Contributor Author

yq314 commented Dec 8, 2021

added a small comment to explain the techpreview status

@mbevc1 mbevc1 merged commit 7033883 into argoproj:master Dec 10, 2021
@mubarak-j mubarak-j mentioned this pull request Dec 10, 2021
Closed
@hairmare hairmare mentioned this pull request Dec 13, 2021
Merged
6 tasks
sylus added a commit to sylus/argo-helm that referenced this pull request Dec 14, 2021
@sylus
Merge branch 'master' into feat-argocd-operator
dcc9834 
* master: (49 commits)
  feat(argo-cd): Add support for argocd-extensions resources (argoproj#1053)
  feat(argo-cd): Add support for extension (argoproj#1050)
  feat(argo-rollouts): Allow setting the type for the dashboard service (argoproj#973)
  feat(argocd-applicationset): Add resources metrics-service and servicemonitor. (argoproj#1041)
  feat(argocd-image-updater): Mount ssh-known-hosts from argocd (argoproj#1040)
  feat(argo-workflows): Add dev/delegated auth (argoproj#1048)
  docs(argo-cd): mention declarative set up for Argo-CD (argoproj#1037)
  feat(argo-cd): Support for additional labels (argoproj#929)
  chore(argocd):  remove myself from CODEOWNERS (argoproj#1044)
  feat(argo-cd): support initContainers on all pods (argoproj#1043)
  bumped appVersion / image to v1.2.0 (argoproj#1039)
  feat(argocd-image-updater): Update to app version v0.11.0 (argoproj#1036)
  feat(argo-cd): add flag and labels for application labels (argoproj#1021)
  fix(argo-workflows): Add missing WorkflowTasksets RBAC to controller (argoproj#1032)
  chore(argocd): remove myself from CODEOWNERS (argoproj#1029)
  feat(argo-workflows): Include pod name in key format for GCS logs (argoproj#915)
  feat(argo-workflows): support resourceRateLimit config (argoproj#1008)
  feat(argocd-image-updater): Add missing config map key for git commit-message-template (argoproj#986)
  feat(argo-workflows): Upgrade argo-workflows to v3.2.4 (argoproj#1030)
  feat(argo-cd): Upgrade argocd to v2.1.7 (argoproj#1024)
  ...
@hairmare hairmare mentioned this pull request Dec 17, 2021
Merged
6 tasks
@mkilchhofer mkilchhofer mentioned this pull request Dec 20, 2021
Merged
5 tasks
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Dec 23, 2021
@yq314 @mbevc1
@mkilchhofer @terrych0u
feat(argo-cd): Add support for extension (argoproj#1050)
da02d65 
* add support for extension

Signed-off-by: Qing Ye <ye.qing@gojek.com>

* add volume mounts

Signed-off-by: Qing Ye <ye.qing@gojek.com>

* add RBAC

Signed-off-by: Qing Ye <ye.qing@gojek.com>

* add more control to extensions values and update readme

Signed-off-by: Qing Ye <ye.qing@gojek.com>

* remove trailing spaces in values file

Signed-off-by: Qing Ye <ye.qing@gojek.com>

* add missing extensions.enabled

Signed-off-by: Qing Ye <ye.qing@gojek.com>

* Update charts/argo-cd/Chart.yaml

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Qing Ye <ye.qing@gojek.com>

* add comment to extensions values

Signed-off-by: Qing Ye <ye.qing@gojek.com>

Co-authored-by: Qing Ye <ye.qing@gojek.com>
Co-authored-by: Marko Bevc <marko@scalefactory.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

@yann-soubeyrand yann-soubeyrand Awaiting requested review from yann-soubeyrand

Assignees
No one assigned
Labels
argo-cd size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support deploying the Argo CD Extensions Controller with argo-cd
3 participants
@yq314 @mbevc1 @mkilchhofer