fix(argo-cd): Update github SSH key fingerprint

[hamza3202]

Fixes: /issues/1019
Github has two new fingerprints. This PR adds those fingerprints to default values.

Ref: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints

Signed-off-by: Muhammad Hamza Zaib hamzazaib3202@gmail.com

Checklist:

• I have bumped the chart version according to versioning
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[hamza3202]

@mbevc1 could you please review this PR? Argo CD is not able to communicate with github right now.

[mbevc1]

@hamza3202 thanks for the contribution. Seems old keys have been dropped. Could we remove those and replace third one as well?
https://api.github.com/meta

Burnout plans: https://github.blog/2021-09-01-improving-git-protocol-security-github/

[hamza3202]

@mbevc1 The three signatures added right now are the correct ones. You can generate and compare the fingerprints with the ones provided at https://api.github.com/meta by doing the following

> echo "ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBEmKSENjQEezOmxkZMy7opKgwFB9nkt5YRrYMjNuG5N87uRgg6CLrbo5wAdT/y6v0mKV0U2w0WZ2YB/++Tpockg=" | tee key | ssh-keygen -lf -
256 SHA256:p2QAMXNIC1TJYWeIOttrVc98/R1BUFWu3/LiyKgUfQM no comment (ECDSA)

> echo "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOMqqnkVzrm0SdG6UOoqKLsabgH5C9okWi0dh2l9GKJl" | tee key | ssh-keygen -lf -
256 SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU no comment (ED25519)

> echo "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==" | tee key | ssh-keygen -lf -
2048 SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8 no comment (RSA)

[idrissneumann]

For information: I did pretty the same fix here: #1020 (which I just closed because this pr is a little bit older ^^ ).

And I opened an issue here that you can link to this pr: #1019

[mkilchhofer]

lgtm. Thanks for your contribution

[mbevc1]

It can be a separate PR, but we probable want to clean up old keys as they are not in use any more. Cheers for adding new ones in 👍

[hamza3202]

It can be a separate PR, but we probable want to clean up old keys as they are not in use any more. Cheers for adding new ones in +1

@mbevc1 which key are you referring to as the old keys?

[mbevc1]

I reckon those are not used anymore:
https://github.com/argoproj/argo-helm/pull/1018/files#diff-9eb59d56febda5e405748483497dfdc0c2dfbe9b4f386a12f0180c98d99051e0R1490-R1491

[hamza3202]

Those are for gitlab not github.

[mbevc1]

Ah, your are right. Sorry about that, GH diff got me confused for a bit here :) All good. Thanks again 👍