Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[argo-rollouts] Add ingress support for dashboard #868

Closed
sergeyshaykhullin opened this issue Aug 16, 2021 · 5 comments · Fixed by #870
Closed

[argo-rollouts] Add ingress support for dashboard #868

sergeyshaykhullin opened this issue Aug 16, 2021 · 5 comments · Fixed by #870
Labels
argo-rollouts awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. enhancement New feature or request

Comments

@sergeyshaykhullin
Copy link
Contributor

sergeyshaykhullin commented Aug 16, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
argo-rollouts 2.0 released https://github.com/argoproj/argo-helm/releases/tag/argo-rollouts-2.0.0

Describe the solution you'd like
Add ingress section to helm chart for dashboard

Describe alternatives you've considered

Additional context
Reuse existing from argo-cd?

WIP: #870
@sergeyshaykhullin sergeyshaykhullin added the enhancement New feature or request label Aug 16, 2021
@mkilchhofer mkilchhofer mentioned this issue Sep 17, 2021
Merged
5 tasks
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@sergeyshaykhullin
Copy link
Contributor Author

@mkilchhofer I opened pr for this

@mkilchhofer
Copy link
Member

Sorry. I thought that this issue is in the upstream repo here: https://github.com/argoproj/argo-rollouts
From my side I only approve your pr #870 if the upstream project accept an ingress in their kustomize manifests.

@mkilchhofer mkilchhofer added awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. and removed no-issue-activity labels Oct 17, 2021
@sergeyshaykhullin sergeyshaykhullin mentioned this issue Oct 17, 2021
Closed
@mkilchhofer mkilchhofer mentioned this issue Oct 18, 2021
Closed
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@sergeyshaykhullin
Copy link
Contributor Author

Not stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
argo-rollouts awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(argo-rollouts): Add rollouts dashboard ingress support sergeyshaykhullin/argo-helm
2 participants
@mkilchhofer @sergeyshaykhullin