Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argo-cd] Add note about argocdServerAdminPassword when deployed through Argo CD #785

Open
mkilchhofer opened this issue Jun 3, 2021 · 4 comments
Labels
argo-cd documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers on-hold Issues or Pull Requests with this label will never be considered stale

Comments

@mkilchhofer
Copy link
Member

mkilchhofer commented Jun 3, 2021

Follow-up issue of #784

When deploying the argo-cd chart via an ArgoCD instance, we need to take care how we inject the argocdServerAdminPassword. If we define it like this:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: argocd-testing
spec:
  destination:
    namespace: testing
    server: https://kubernetes.default.svc
  project: default
  source:
    chart: argo-cd
    repoURL: https://argoproj.github.io/argo-helm
    targetRevision: 3.21.0
    helm:
      parameters:
      - name: configs.secret.argocdServerAdminPassword
        value: $2a$10$H1a30nMr9v2QE2nkyz0BoOD2J0I6FQFMtHS0csEg12RBWzfRuuoE6

It does not work because ArgoCD uses variable substitution in the parameters section.

However, if we define it in the values section, this works as expected:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: argocd-testing
spec:
  destination:
    namespace: testing
    server: https://kubernetes.default.svc
  project: default
  source:
    chart: argo-cd
    repoURL: https://argoproj.github.io/argo-helm
    targetRevision: 3.21.0
    helm:
      values: |
        configs:
          secret:
            argocdServerAdminPassword: $2a$10$H1a30nMr9v2QE2nkyz0BoOD2J0I6FQFMtHS0csEg12RBWzfRuuoE6

We should at least place a hint inside the Chart's README.md

@mkilchhofer mkilchhofer added enhancement New feature or request documentation Improvements or additions to documentation labels Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Aug 7, 2021

Stale issue message

@mkilchhofer
Copy link
Member Author

not stale

@github-actions

This comment has been minimized.

@github-actions github-actions bot closed this as completed Dec 3, 2021
@mkilchhofer mkilchhofer reopened this Dec 3, 2021
@mkilchhofer mkilchhofer added the on-hold Issues or Pull Requests with this label will never be considered stale label Jan 17, 2022
@mkilchhofer mkilchhofer self-assigned this Jan 17, 2022
@Jojoooo1
Copy link

same issue

@mkilchhofer mkilchhofer removed their assignment Sep 3, 2024
@mkilchhofer mkilchhofer added the good first issue Good for newcomers label Sep 3, 2024
@mkilchhofer mkilchhofer changed the title [argo-cd] Add note about argocdServerAdminPassword when deployed through ArgoCD [argo-cd] Add note about argocdServerAdminPassword when deployed through Argo CD Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers on-hold Issues or Pull Requests with this label will never be considered stale
Projects
None yet
Development

No branches or pull requests

2 participants