Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity rollout out of sync when using scaleDown property #2418

Closed
ozlotusflare opened this issue Jan 10, 2024 · 3 comments
Closed

Infinity rollout out of sync when using scaleDown property #2418

ozlotusflare opened this issue Jan 10, 2024 · 3 comments
Labels
argo-rollouts awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. question

Comments

@ozlotusflare
Copy link

ozlotusflare commented Jan 10, 2024

Describe the bug

Hi everyone!
I faced with infinity sync loop when I tried to follow this migration doc form deployment to rollout. Basically this workloadRef.scaleDown option cause this , probably because no definition in a CRD
Screenshot 2024-01-10 at 6 05 53 PM

Related helm chart

argo-rollouts

Helm chart version

2.34.1

To Reproduce

# Not working rollout spec
...
  workloadRef:                                 # Reference an existing Deployment using workloadRef field
    apiVersion: apps/v1
    kind: Deployment
    name: rollout-ref-deployment
    scaleDown: onsuccess
...
# Working rollout spec
...
  workloadRef:                                 # Reference an existing Deployment using workloadRef field
    apiVersion: apps/v1
    kind: Deployment
    name: rollout-ref-deployment
...

Expected behavior

Working scaleDown: spec

Screenshots

No response

Additional context

No response

@ozlotusflare ozlotusflare added the bug Something isn't working label Jan 10, 2024
@yu-croco
Copy link
Collaborator

yu-croco commented Jan 11, 2024

Hi @ozlotusflare , Argo Rollouts v1.6.4 doesn't have workloadRef.scaleDown .
Ref: https://github.com/argoproj/argo-rollouts/blob/v1.6.4/manifests/crds/rollout-crd.yaml

On the other hand, master branch has it, which means this feature is not released officially yet in v1.6.4.
Ref: https://github.com/argoproj/argo-rollouts/blob/master/manifests/crds/rollout-crd.yaml#L3400

Let's wait to be released.

@yu-croco yu-croco added awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. question and removed bug Something isn't working labels Jan 11, 2024
@ozlotusflare
Copy link
Author

ozlotusflare commented Jan 12, 2024

Hi @yu-croco,
Thank you for clarification, it's a bit confusing, because in documentation this option already present :)
Anyway, let's wait !

@yu-croco
Copy link
Collaborator

yu-croco commented Jan 13, 2024

it's a bit confusing, because in documentation this option already present :)

FYI
I think this is because the doc shows latescondition, maybe not latest specific version but master's condition. 😇
Anyway, when upstream releases new version, we (argo-helm) follows. :)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-rollouts awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. question
Projects
None yet
Development

No branches or pull requests

2 participants