fix: Add proxy registry key by dest server + name #21791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21791 +/- ##
=========================================
Coverage ? 53.79%
=========================================
Files ? 339
Lines ? 56814
Branches ? 0
=========================================
Hits ? 30561
Misses ? 23661
Partials ? 2592 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
crenshaw-dev
approved these changes
Feb 5, 2025
|
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
|
/cherry-pick release-2.14 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
leoluz
added a commit
that referenced
this pull request
Feb 5, 2025
#21794) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
leoluz
added a commit
that referenced
this pull request
Feb 5, 2025
#21793) Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression:
Argo CD Proxy registry was broken for cases when multiple services were configured for one extension.
The proxy extension lookup was working as expected in Argo CD 2.13.1 and broken on 2.13.3.
Adding a new key in the registry containing the destination name + server addresses the problem.
I wasn't able to confirm 100% but I suspect that this bug was introduced by the following PR: #21063
This fix needs to be cherry-picked in 2.13 and 2.14 branches
Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com