Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to add other resources in validResources of rbac #345

Open
Ajay-Chidambaram opened this issue Oct 29, 2023 · 4 comments
Open

need to add other resources in validResources of rbac #345

Ajay-Chidambaram opened this issue Oct 29, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Community help wanted! Stale

Comments

@Ajay-Chidambaram
Copy link

Description

Need to include other resources like applicationsets, extension, certificates .. in the validResources for the rbac

Potential Terraform Configuration

So far it seems only the below resources are supported through this provider

var validResources = map[string]bool{
	"applications": true,
	"repositories": true,
	"clusters":     true,
	"exec":         true,
	"logs":         true,
}

References

I don't see any issues wrt to this.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@Ajay-Chidambaram Ajay-Chidambaram added the enhancement New feature or request label Oct 29, 2023
@onematchfox
Copy link
Collaborator

For full set of resources see https://github.com/argoproj/argo-cd/blob/master/server/rbacpolicy/rbacpolicy.go. Where possible we should use code exported by that package.

@onematchfox onematchfox added the help wanted Community help wanted! label Oct 30, 2023
@Ajay-Chidambaram
Copy link
Author

For full set of resources see https://github.com/argoproj/argo-cd/blob/master/server/rbacpolicy/rbacpolicy.go. Where possible we should use code exported by that package.

Oh my bad, so is it something which needs to be fixed from argo-cd project side in the first place ?

@onematchfox
Copy link
Collaborator

Oh my bad, so is it something which needs to be fixed from argo-cd project side in the first place ?

Nope. We need to keep the list here in sync with ArgoCD - our code is based on an older, outdated implementation copied from ArgoCD. I was just leaving pointers for anyone who may want to try tackling this.

Copy link

github-actions bot commented Oct 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Community help wanted! Stale
Projects
None yet
Development

No branches or pull requests

2 participants