-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to set annotations+labels on pods created by argocd #637
Comments
A better question to ask is: Why does the operator not support the exact same options as the helm charts? Istio Operator does the same, as do other operators. It would be trivial and super beneficial |
@Morriz I agree it is very useful, but I see a concern with operator reconciling the labels and annotations. There is a good chance that operator may removes annotations/labels set by admission controllers. WDYT ? |
That is a matter of having a mature operator that allows for labels it does not manage. That is why one namespaces them, in order to filter. |
LGTM. Would you like to work on this one ? If not I can add the label Thanks @Morriz |
I am no Go dev unfortunately, and my calendar is rather full ;| |
#1532 implemented support to add custom annotations and labels on Argo CD component pods created by Operator. New fields are introduced in ArgoCD CR to support this. Refer custom_labels_annotations.md for more details. It will be available in upcoming 0.13.0 release . |
Is your feature request related to a problem? Please describe.
Hi, we need to set annotations on any pods running on our cluster, but I can't find the option to do so on pods deployed by argo.
Describe the solution you'd like
Something like:
The text was updated successfully, but these errors were encountered: