Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid image digest for OLM catalog deployment (release-0.12) #1548

Open
bendudz opened this issue Sep 25, 2024 · 5 comments
Open

Invalid image digest for OLM catalog deployment (release-0.12) #1548

bendudz opened this issue Sep 25, 2024 · 5 comments

Comments

@bendudz
Copy link

bendudz commented Sep 25, 2024

Describe the bug
When installing the ArgoCD Operator via OLM, the docker image digest that is required by the OLM install plan is invalid.

To Reproduce
Following this guide, assuming you have OLM setup in Kubernetes when adding a subscription to the release-0.12 version of argocd-operator the image digest of the operator is incorrect.

Install ArgoCD Operator into OLM:

kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-operator/refs/heads/release-0.12/deploy/catalog_source.yaml
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-operator/refs/heads/release-0.12/deploy/operator_group.yaml
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-operator/refs/heads/release-0.12/deploy/subscription.yaml

Wait for the install plan to start kubectl get install plans -n argocd.

A deployment will appear in the argocd namespace which can't create the pod due to 'invalid checksum digest length'.

The image its trying to create the pod with is: quay.io/argoprojlabs/argocd-operator@sha256:405e7bde25affb7644c576a7f2d41ba30b88e2ef4f2f11945b920a33517895cee

However the image available in quay here is quay.io/argoprojlabs/argocd-operator@sha256:405e7bde25affb7644c576a7f2d41ba30b88e2ef4f2f11945b920a33517895ce notice the last 'e' is missing.

Expected behavior
I'd expect the ArgoCD Operator to be able to be deployed via OLM without error.

The digest causing the issue is hardcoded here:

image: quay.io/argoprojlabs/argocd-operator@sha256:405e7bde25affb7644c576a7f2d41ba30b88e2ef4f2f11945b920a33517895cee

On the surface it's a simple typo to fix but I was unsure if this is caused by your build process otherwise I'd have offered a PR to fix. If you can advise I'll create a fix for it. Thanks

@saumeya
Copy link
Collaborator

saumeya commented Sep 26, 2024

Thanks @bendudz for catching this, it is indeed a typo and is not caused due to build process. I have created a fix here - #1549 . Once it is merged, please try again and it should work.

@svghadi
Copy link
Collaborator

svghadi commented Sep 26, 2024

Thanks @saumeya.

@bendudz - The PR is merged to fix the typo. Can you try now and confirm?

@bendudz
Copy link
Author

bendudz commented Sep 26, 2024

Hi @svghadi @saumeya, it's still got the same issue. I did see another 2 occurrences in the release but unsure what they are used for.

Here
Here

Just copied the bundles.db out of the catalog container and can see the ...95cee digest in there. Will this image require a rebuild?

@saumeya
Copy link
Collaborator

saumeya commented Sep 26, 2024

Thanks for the prompt response, taking a look at this.

@saumeya
Copy link
Collaborator

saumeya commented Oct 1, 2024

@bendudz it is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants