Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump k8s.io/apimachinery to 0.31.2, add k8s.io/cri-client and k8s.io/endpointslice to replace section #938

Merged

Conversation

chengfang
Copy link
Collaborator

  • bump k8s.io/apimachinery to 0.31.2, to be consistent with argo-cd
  • while everything builds and runs fine in command line, when loading the project in my ide, I'm seeing errors like the following. Adding k8s.io/cri-client and k8s.io/endpointslice to the replace section fixes the problem.
go: k8s.io/cri-client@v0.0.0: invalid version: unknown revision v0.0.0

…t and k8s.io/endpointslice to replace section

Signed-off-by: Cheng Fang <cfang@redhat.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (6273814) to head (9efc196).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #938   +/-   ##
=======================================
  Coverage   74.64%   74.64%           
=======================================
  Files          31       31           
  Lines        3913     3913           
=======================================
  Hits         2921     2921           
  Misses        856      856           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit edb67c6 into argoproj-labs:master Nov 15, 2024
10 checks passed
@chengfang chengfang deleted the cri-client.endpointslice branch November 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants