Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent E2E test error due to 'failed to reconcile Rollout's Metrics Service.' #81

Closed
jgwest opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jgwest
Copy link
Member

jgwest commented Jul 30, 2024

Seeing this intermittent E2e test error in a couple of PRs. More specifically, the mechanism for detecting unexpected errors is flagging these lines.

We should either add them to the ignore list, or figure out why they are being output:

2024-07-22T16:28:53.6773824Z 2024-07-22T16:28:53Z	INFO	rollouts-controller	Creating Service argo-rollouts-metrics
2024-07-22T16:28:53.6919812Z 2024-07-22T16:28:53Z	ERROR	rollouts-controller	Error creating Service	{"Name": "argo-rollouts-metrics", "error": "services \"argo-rollouts-metrics\" already exists"}
2024-07-22T16:28:53.6923050Z github.com/argoproj-labs/argo-rollouts-manager/controllers.(*RolloutManagerReconciler).reconcileRolloutsMetricsService
2024-07-22T16:28:53.6928676Z 	/home/runner/work/argo-rollouts-manager/argo-rollouts-manager/controllers/resources.go:433
2024-07-22T16:28:53.6930839Z github.com/argoproj-labs/argo-rollouts-manager/controllers.(*RolloutManagerReconciler).reconcileRolloutsManager
2024-07-22T16:28:53.6933080Z 	/home/runner/work/argo-rollouts-manager/argo-rollouts-manager/controllers/reconcile.go:125
2024-07-22T16:28:53.6935049Z github.com/argoproj-labs/argo-rollouts-manager/controllers.(*RolloutManagerReconciler).Reconcile
2024-07-22T16:28:53.6937264Z 	/home/runner/work/argo-rollouts-manager/argo-rollouts-manager/controllers/argorollouts_controller.go:144
2024-07-22T16:28:53.6939243Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
2024-07-22T16:28:53.6941285Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119
2024-07-22T16:28:53.6943251Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
2024-07-22T16:28:53.6945440Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316
2024-07-22T16:28:53.6947403Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
2024-07-22T16:28:53.6949658Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266
2024-07-22T16:28:53.6951613Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
2024-07-22T16:28:53.6953678Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227
2024-07-22T16:28:53.6956379Z 2024-07-22T16:28:53Z	ERROR	rollouts-controller	failed to reconcile Rollout's Metrics Service.	{"error": "services \"argo-rollouts-metrics\" already exists"}
2024-07-22T16:28:53.6959451Z github.com/argoproj-labs/argo-rollouts-manager/controllers.(*RolloutManagerReconciler).reconcileRolloutsManager
2024-07-22T16:28:53.6961772Z 	/home/runner/work/argo-rollouts-manager/argo-rollouts-manager/controllers/reconcile.go:126
2024-07-22T16:28:53.6963903Z github.com/argoproj-labs/argo-rollouts-manager/controllers.(*RolloutManagerReconciler).Reconcile
2024-07-22T16:28:53.6966075Z 	/home/runner/work/argo-rollouts-manager/argo-rollouts-manager/controllers/argorollouts_controller.go:144
2024-07-22T16:28:53.6967925Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
2024-07-22T16:28:53.6970117Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119
2024-07-22T16:28:53.6972120Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
2024-07-22T16:28:53.6974229Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316
2024-07-22T16:28:53.6976438Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
2024-07-22T16:28:53.6978557Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266
2024-07-22T16:28:53.6980386Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
2024-07-22T16:28:53.6982422Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227
@jgwest jgwest added the bug Something isn't working label Jul 30, 2024
@jgwest jgwest self-assigned this Jul 30, 2024
@jgwest
Copy link
Member Author

jgwest commented Oct 24, 2024

This appears to be resolved.

@jgwest jgwest closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant