Skip to content

Commit 3560a97

Browse files
committed
fix(VuforiaService): resolve url in createDataSetFromURL
1 parent 5826c97 commit 3560a97

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/vuforia.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export class VuforiaObjectTracker extends VuforiaTracker {
132132
* Deprecated. Please use createDataSetFromURI instead.
133133
* @deprecated To be removed.
134134
*/
135-
@deprecated('createDataSetFromURI')
135+
@deprecated('createDataSetFromURL')
136136
public createDataSet(url?: string): Promise<DeprecatedVuforiaDataSet> {
137137
if (url && window.document) {
138138
url = resolveURL(url);
@@ -148,13 +148,19 @@ export class VuforiaObjectTracker extends VuforiaTracker {
148148
* Fetch a dataset from the provided url.
149149
* If successfull, resolves to an id which represents the dataset.
150150
*/
151-
public createDataSetFromURI(uri: string) : Promise<VuforiaDataSetId> {
152-
return this.managerSession.request('ar.vuforia.objectTrackerCreateDataSet', { uri })
151+
public createDataSetFromURL(url: string) : Promise<VuforiaDataSetId> {
152+
if (url && window.document) {
153+
url = resolveURL(url);
154+
}
155+
return this.managerSession.request('ar.vuforia.objectTrackerCreateDataSet', { url })
153156
.then((message: { id: VuforiaDataSetId }) => {
154157
return message.id;
155158
});
156159
}
157160

161+
@deprecated('createDataSetFromURL')
162+
public get createDataSetFromURI() { return this.createDataSetFromURL };
163+
158164
/**
159165
* Load the dataset into memory, and return a promise which
160166
* resolves to the contained trackables

0 commit comments

Comments
 (0)