Skip to content

Remove duplicate worker deployment labels #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AndersBennedsgaard
Copy link

Description

Removed duplicate worker deployment labels, which created invalid YAML.
This bug made it impossible to use Kustomize with Helm, since Kustomize validates YAML (Helm apparently skips this validation).

Closes #5788

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

helm template argilla examples/deployments/k8s/argilla-chart

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG-python/deployment] Duplicate labels in helm chart
1 participant