Do not detect proxy directories inside vendor directories as entrypoints #245
Conversation
🦋 Changeset detectedLatest commit: a4dc8a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } catch { | ||
| return false; | ||
| const packageJson = JSON.parse(fs.readFile(file)); | ||
| if (packageJson.name && !packageJson.name.startsWith(fs.packageName)) { |
There was a problem hiding this comment.
This is already here in the old code, but I didn't realize that the name mattered at all for these marker-style package.jsons; I figured it didn't really matter much
There was a problem hiding this comment.
This whole thing is just heuristics, but the idea is that your own subpackages are likely to be named "my-root-package/subdir" or not have a name at all. If the name is something else entirely, you’ve probably just vendored another package.
There was a problem hiding this comment.
In this case, I feel like ignoring nested node_modules would probablty also have worked (since that itself is a no-no that shouldn't have been able to happen)
There was a problem hiding this comment.
That would work for this case, but it wouldn't work for packages that vendor other packages in a folder not called node_modules, which next does. (It just happens not to have any vendored packages that contain subfolders with nameless package.json files.)
No description provided.