-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when PWM1i is defined when using command wakeup #9466
Comments
The crash with PWM 7022 was a WDT reboot with no stack trace (even not with serial attached). Is the crash with ws2812 similar? |
The crashes with wd2812 were exceptions 0. Bad thing now is I cannot reproduce... Investigating. |
Fix light wakeup exception 0 (divide by zero) when ``WakeupDuration`` is not initialised (#9466)
Wakeup exception 0 fixed by latest commit Background information. Received exception 0 like this:
Using valid .map file see:
The main issue is the first one (udivsi3) executed by LightAnimate. Searching source reveals the only divide in Animate() is this:
Checking the value of Settings.light_wakeup using command The fix makes sure Settings.light_wakeup will never be 0 again. |
Did test with div 0 fix. Wakeup does work now in general. |
Agree. Pls provide pr |
to solve arendst#9466
+1. We just need to check the max frequency of 7231 because of impact on pwm fan |
@s-hadinger did a test (pwm fan). Delivers a good signal at frequencys high enough for pwm fans. |
Define a GPIO with function PWM1i.
Use command
LedTable 1
andDimmer 3
after that fire commandwakeup
-> crash.Sometimes it already crashes with the
Dimmer
command.Compiling Tasmota @160Mhz for the ESP makes it even worse.
The issue is already discussed in Discord. The crash is proabably caused from the used PWM code.
Tasmota actual uses PR esp8266/Arduino#7022 for Tasmota core 2.7.4.1
( https://github.com/tasmota/Arduino/tree/2.7.4.1-tasmota )
With some! tests it seems the issue is fixed using PR esp8266/Arduino#7231 instead.
( https://github.com/tasmota/Arduino/tree/2.7.4.1-PR7231 )
The shutter part and the AC-Zero-Cross Dimmer needs testing for compability for the changed PWM part.
@stefanbode and everyone else is invited to do tests. Thx in advance for doing.
For doing this download the
provided platformio_override.ini.txt
. Rename it toplatformio_override.ini
and copy it to yourroot file of the Tasmota project folder. Rename your override file before ;-)
platformio_override.ini.txt
-->
PROBLEM DESCRIPTION
A clear and concise description of what the problem is.
REQUESTED INFORMATION
Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!
Backlog Template; Module; GPIO 255
:Backlog Rule1; Rule2; Rule3
:Status 0
:(Please use
weblog 4
for more debug information)TO REPRODUCE
see above
EXPECTED BEHAVIOUR
no crash
SCREENSHOTS
If applicable, add screenshots to help explain your problem.
ADDITIONAL CONTEXT
Add any other context about the problem here.
(Please, remember to close the issue when the problem has been addressed)
The text was updated successfully, but these errors were encountered: