option strip empty tag when using with maxLines

[ng-ha]

Hey, thanks for greet package, @arendjr !

It would be helpful if text-clipper has option to strip empty tag.

For example:

clip( '<p><img/></p><p>abc</p>',  3,  {
    html: true,
    stripTags: ['img'],
    maxLines: 1,
  })

returns

'<p></p>'

which isn't what i wanted.

I want this:

'<p>abc</p>'

Can you provide me a workaround, please! Thank you!

[ng-ha]

i found a workaround:

• first, remove tags: const strippedHtml = clip(html, Infinity, {html: true, stripTags: ['img', 'br']});
• then remove empty tags: const sanitizedHtml = strippedHtml.replace(/<[^>]>[\s\r\n]</[^>]*>/g, '')
• finally, clip it: clip(sanitizedHtml, 40, {html: true, maxLines: 1});

[arendjr]

Thanks for the feedback!

I think your suggestion makes a lot of sense. In fact, I think a variation of this makes sense for the plain-text clipper too:

clip( '\nabc',  3,  {
    maxLines: 1,
})

I didn’t actually check what it returns, but I’m afraid you’ll only get ellipsis, while ”abc” would be a more desirable output in many cases.

I’m thinking it might make sense to introduce an omitEmptyLines option which in the HTML would omit empty paragraphs too, including when such a paragraph is created by stripping other tags.

I’d be happy to accept a PR for this!