Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INS_RESET does not reset PIN policy #41

Closed
MichaelGrafnetter opened this issue Jan 19, 2021 · 3 comments
Closed

INS_RESET does not reset PIN policy #41

MichaelGrafnetter opened this issue Jan 19, 2021 · 3 comments

Comments

@MichaelGrafnetter
Copy link

Hi, is there a specific reason why the PivApplet.processReset() method does not reset slot-specific PIN policies to their default values on INS_RESET? Or is it a bug?

I would expect something like this to be present:

slots[SLOT_9A].pinPolicy = PivSlot.P_ONCE;
slots[SLOT_9C].pinPolicy = PivSlot.P_ALWAYS;
slots[SLOT_9D].pinPolicy = PivSlot.P_ONCE;
slots[SLOT_9E].pinPolicy = PivSlot.P_NEVER;
for (byte i = SLOT_82; i <= SLOT_8C; ++i)
    slots[i].pinPolicy = PivSlot.P_ONCE;
@arekinath
Copy link
Owner

Looks like a bug to me. Thanks for pointing it out, I'll try to get a fix in for it at some point.

@MichaelGrafnetter
Copy link
Author

Great, thanks for the fix! Are you planning on creating a new release, please?

@arekinath
Copy link
Owner

Released in v0.9.0 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants