Skip to content

Commit f5a0c48

Browse files
committed
Reduce line length to <=120 in YAML files where feasible
120 columns is the recommended line length for YAML code in Arduino tooling projects. The yamllint tool used by the "Check YAML" template produces a warning when a line exceeds this length. This is not a hard limit and in some cases it is either impossible or not beneficial to make lines less than 120 in length so some violations of the guideline are unavoidable. However, in the case of these particular long lines, breaking them into multiple lines does improve the readability of the code.
1 parent 41871d7 commit f5a0c48

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.github/workflows/release-go-crosscompile-task.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@ jobs:
121121
env:
122122
KEYCHAIN: "sign.keychain"
123123
INSTALLER_CERT_MAC_PATH: "/tmp/ArduinoCerts2020.p12"
124-
KEYCHAIN_PASSWORD: keychainpassword # Arbitrary password for a keychain that exists only for the duration of the job, so not secret
124+
# Arbitrary password for a keychain that exists only for the duration of the job, so not secret
125+
KEYCHAIN_PASSWORD: keychainpassword
125126
run: |
126127
echo "${{ secrets.INSTALLER_CERT_MAC_P12 }}" | base64 --decode > "${{ env.INSTALLER_CERT_MAC_PATH }}"
127128
security create-keychain -p "${{ env.KEYCHAIN_PASSWORD }}" "${{ env.KEYCHAIN }}"

Taskfile.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ vars:
3232
DEFAULT_GO_MODULE_PATH: ./
3333
DEFAULT_GO_PACKAGES:
3434
sh: |
35-
echo $(cd {{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}} && go list ./... | tr '\n' ' ' || echo '"ERROR: Unable to discover Go packages"')
35+
echo $(
36+
cd {{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}} &&
37+
go list ./... | tr '\n' ' ' ||
38+
echo '"ERROR: Unable to discover Go packages"'
39+
)
3640
3741
tasks:
3842
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-workflows-task/Taskfile.yml

0 commit comments

Comments
 (0)