Replaced outdated executils library

Author: cmaglie

ls/builder.go

@@ -27,7 +27,6 @@ import (
 
 	"github.com/arduino/arduino-cli/arduino/builder"
 	"github.com/arduino/arduino-cli/arduino/libraries"
-	"github.com/arduino/arduino-cli/executils"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 	"github.com/arduino/arduino-language-server/sourcemapper"
 	"github.com/arduino/arduino-language-server/streams"
@@ -275,7 +274,7 @@ func (ls *INOLanguageServer) generateBuildEnvironment(ctx context.Context, fullB
 		}
 
 		// Run arduino-cli to perform the build
-		args := []string{config.CliPath.String(),
+		args := []string{
 			"--config-file", config.CliConfigPath.String(),
 			"compile",
 			"--fqbn", config.Fqbn,
@@ -289,7 +288,7 @@ func (ls *INOLanguageServer) generateBuildEnvironment(ctx context.Context, fullB
 		}
 		args = append(args, sketchRoot.String())
 
-		cmd, err := executils.NewProcess(nil, args...)
+		cmd, err := paths.NewProcessFromPath(nil, config.CliPath, args...)
 		if err != nil {
 			return false, errors.Errorf("running %s: %s", strings.Join(args, " "), err)
 		}

ls/ls.go

@@ -28,7 +28,6 @@ import (
 	"sync"
 	"time"
 
-	"github.com/arduino/arduino-cli/executils"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/settings/v1"
 	"github.com/arduino/arduino-language-server/globals"
 	"github.com/arduino/arduino-language-server/sourcemapper"
@@ -1449,13 +1448,13 @@ func (ls *INOLanguageServer) extractDataFolderFromArduinoCLI(logger jsonrpc.Func
 		}
 		logger.Logf("Arduino Data Dir -> %s", dataDir)
 	} else {
-		args := []string{ls.config.CliPath.String(),
+		args := []string{
 			"--config-file", ls.config.CliConfigPath.String(),
 			"config",
 			"dump",
 			"--format", "json",
 		}
-		cmd, err := executils.NewProcess(nil, args...)
+		cmd, err := paths.NewProcessFromPath(nil, ls.config.CliPath, args...)
 		if err != nil {
 			return nil, errors.Errorf("running %s: %s", strings.Join(args, " "), err)
 		}

ls/lsp_client_clangd.go

@@ -22,7 +22,6 @@ import (
 	"os"
 	"strings"
 
-	"github.com/arduino/arduino-cli/executils"
 	"github.com/arduino/arduino-language-server/streams"
 	"github.com/arduino/go-paths-helper"
 	"github.com/fatih/color"
@@ -49,23 +48,22 @@ func newClangdLSPClient(logger jsonrpc.FunctionLogger, dataFolder *paths.Path, l
 
 	// Start clangd
 	args := []string{
-		ls.config.ClangdPath.String(),
 		"-log=verbose",
 		fmt.Sprintf(`--compile-commands-dir=%s`, ls.buildPath),
 	}
 	if dataFolder != nil {
 		args = append(args, fmt.Sprintf("-query-driver=%s", dataFolder.Join("packages", "**").Canonical()))
 	}
 
-	logger.Logf("    Starting clangd: %s", strings.Join(args, " "))
+	logger.Logf("    Starting clangd: %s %s", ls.config.ClangdPath, strings.Join(args, " "))
 	var clangdStdin io.WriteCloser
 	var clangdStdout, clangdStderr io.ReadCloser
 	var extraEnv []string
 	if ls.tempDir != nil {
 		extraEnv = append(extraEnv, "TMPDIR="+ls.tempDir.String()) // For unix-based systems
 		extraEnv = append(extraEnv, "TMP="+ls.tempDir.String())    // For Windows
 	}
-	if clangdCmd, err := executils.NewProcess(extraEnv, args...); err != nil {
+	if clangdCmd, err := paths.NewProcessFromPath(extraEnv, ls.config.ClangdPath, args...); err != nil {
 		panic("starting clangd: " + err.Error())
 	} else if cin, err := clangdCmd.StdinPipe(); err != nil {
 		panic("getting clangd stdin: " + err.Error())