Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested cloud sketch folder sync #2388

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kittaakos
Copy link
Contributor

Motivation

This is a work-in-progress IDE2 activity for supporting custom libraries inside nested folders of the sketch folder: arduino/arduino-cli#2514

Change description

  • fix remap Create API 404 error to VS Code FileSystem-specific error,
  • order resource creation to ensure the container folder of nested resources already exists,
  • initial support of creating folders from the Sketchbook view

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Akos Kitta added 3 commits February 23, 2024 08:51
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
longest path comes first to remove to most nested resources, then their
container if any.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: cloud Related to Arduino Cloud and cloud sketches labels Feb 23, 2024
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants