Skip to content

No user feedback when pushing an already deleted remote sketch #1842

Open

Description

Describe the problem

Source: #1825 (comment)

Users can push an already deleted sketch to the remote. Nothing happens, no user feedback. The sketch disappears.

To reproduce

5. Can push a remotely deleted sketch. After the push, the sketch disappears from the sketchbook. No notification that it was deleted remotely and the push has failed:

Uncaught (in promise) Error: Unable to write file '/sketch_jan23bm/sketch_jan23bm.ino' (Error: Not found: /sketch_jan23bm.)
    at FileService.asFileOperationError (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:647:36)
    at FileService.rethrowAsFileOperationError (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:644:20)
    at FileService.writeFile (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:537:18)
    at async FileService.write (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:416:30)
    at async Promise.all (index 1)
    at async CloudSketchbookTree.sync (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…_esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22367:9)
    at async file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22254:13
    at async CloudSketchbookTree.runWithState (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22352:28)
    at async CommandRegistry.executeCommand (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/bundle.js:57068:28)
Caused by: Error: Not found: /sketch_jan23bm.
    at CreateApi.stat (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:11592:19)
    at async CreateFsProvider.stat (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:11893:26)
    at async FileService.mkdirp (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:886:30)
    at async FileService.writeFile (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:503:17)
    at async FileService.write (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:416:30)
    at async Promise.all (index 1)
    at async CloudSketchbookTree.sync (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…_esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22367:9)
    at async file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22254:13
    at async CloudSketchbookTree.runWithState (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22352:28)
    at async CommandRegistry.executeCommand (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/bundle.js:57068:28)

Expected behavior

There is user feedback that the push is not possible anymore.

Arduino IDE version

2.0.3.

Operating system

macOS

Operating system version

12.5.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    topic: cloudRelated to Arduino Cloud and cloud sketchestopic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions