Enable rename and delete options for Cloud Sketch and/or any of its files

[davegarthsimpson]

Describe the request

Allow the renaming and deletion of cloud sketches and individual additional files in cloud sketches via the Arduino IDE UI.

Describe the current behavior

It is not possible to rename or delete cloud (AKA "remote") sketches using Arduino IDE.

It is not possible to rename or delete individual additional files of cloud sketches using Arduino IDE:

Arduino IDE version

afb02da

Operating system

All

Operating system version

Any

Additional context

This will require investigation on allowed API calls and their repercussions

Issue checklist

• I searched for previous requests in the issue tracker
• I verified the feature was still missing when using the latest nightly build
• My request contains all necessary details

[kittaakos]

What does the deletion/rename intend to do here? Is it a brute force modification on the remote sketch when the user executes it or is this operation changes the local sketch only then the user has to push the changes to the remote to have the desired delete/rename effect?

Whenever a new file is created or file content changes, the changes are not automatically applied to the remote content but only to the local cache and users have to push the changes manually. Does IDE2 want to provide different behavior for rename/delete and new/update?

Can you please help define the expected behavior @91volt? Maybe you had the chance to discuss it with @ubidefeo when you designed the new feature. Thank you!

[kittaakos]

Rename/Delete must be avail from the sketchbook view.

[kittaakos]

Related bugs:

1. pull deleted sketch:
   • Create cloud sketch,
   • Open IDE2. The new sketch is visible,
   • Delete the cloud sketch from the browser,
   • Pull cloud sketch in IDE2.

Uncaught (in promise) Error: Not found: /yyy444.
    at CreateApi.stat (create-api.ts:236)
    at async CreateFsProvider.stat (create-fs-provider.ts:92)
    at async FileService.doResolveFile (file-service.ts:499)
    at async FileService.resolve (file-service.ts:477)
    at async CloudSketchbookTree.resolveFileStat (cloud-sketchbook-tree.ts:427)
    at async CloudSketchbookTree.resolveChildren (file-tree.ts:38)
    at async FileNavigatorFilter.filter (navigator-filter.ts:51)
    at async CloudSketchbookTree.resolveChildren (sketchbook-tree.ts:25)
    at async CloudSketchbookTree.resolveChildren (cloud-sketchbook-tree.ts:382)
    at async CloudSketchbookTree.refresh (tree.ts:306)

Moved to #1840.

---

2. Renamed cloud sketch remains in the cache folder

• Create a cloud sketch,
• Open IDE2, pull the newly created cloud sketch, and open it in a new window,
• Rename cloud sketch in the browser,
• Pull the sketch. Nothing happens, there is an error in the console:

uncaught (in promise) Error: Not found: /rrrr_tttt.
    at CreateApi.stat (/Users/a.kitta/dev/g…t_l-bf9e6e.js:11592)
    at async CreateFsProvider.stat (/Users/a.kitta/dev/g…t_l-bf9e6e.js:11893)
    at async FileService.doResolveFile (/Users/a.kitta/dev/g…e-service_js.js:270)
    at async FileService.resolve (/Users/a.kitta/dev/g…e-service_js.js:254)
    at async CloudSketchbookTree.resolveFileStat (/Users/a.kitta/dev/g…t_l-bf9e6e.js:22416)
    at async CloudSketchbookTree.resolveChildren (/Users/a.kitta/dev/g…og_index_js.js:1924)
    at async FileNavigatorFilter.filter (/Users/a.kitta/dev/g…or-widget_js.js:988)
    at async CloudSketchbookTree.resolveChildren (/Users/a.kitta/dev/g…t_l-bf9e6e.js:24272)
    at async CloudSketchbookTree.resolveChildren (/Users/a.kitta/dev/g…t_l-bf9e6e.js:22382)
    at async CloudSketchbookTree.refresh (bundle.js:53231)

• Sync the cloud sketchbook view. A sketch is pulled (the new cloud sketch with its new name), but the currently opened sketch is not visible in the sketchbook tree. After the pull, the current cloud sketch is dangling. The sketch with its old name remains in the cache folder under directories.data/CloudSketchbook/ArduinoCloud
• The IDE2 is fully functional (verify, upload are OK)
• Quit + start IDE2, the dangling sketch opens, IDE2 is working, but the sketch is not visible in the sketchbook view.

Moved to #1841

---

3. Can push a remotely deleted sketch. After the push, the sketch disappears from the sketchbook. No notification that it was deleted remotely and the push has failed:

Uncaught (in promise) Error: Unable to write file '/sketch_jan23bm/sketch_jan23bm.ino' (Error: Not found: /sketch_jan23bm.)
    at FileService.asFileOperationError (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:647:36)
    at FileService.rethrowAsFileOperationError (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:644:20)
    at FileService.writeFile (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:537:18)
    at async FileService.write (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:416:30)
    at async Promise.all (index 1)
    at async CloudSketchbookTree.sync (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…_esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22367:9)
    at async file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22254:13
    at async CloudSketchbookTree.runWithState (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22352:28)
    at async CommandRegistry.executeCommand (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/bundle.js:57068:28)
Caused by: Error: Not found: /sketch_jan23bm.
    at CreateApi.stat (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:11592:19)
    at async CreateFsProvider.stat (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:11893:26)
    at async FileService.mkdirp (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:886:30)
    at async FileService.writeFile (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:503:17)
    at async FileService.write (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/vendors-node_modules_theia_filesystem_lib_browser_file-service_js.js:416:30)
    at async Promise.all (index 1)
    at async CloudSketchbookTree.sync (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…_esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22367:9)
    at async file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22254:13
    at async CloudSketchbookTree.runWithState (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/node_modules_the…esm_vs_base_common_sync_recursive-node_modules_moment_l-bf9e6e.js:22352:28)
    at async CommandRegistry.executeCommand (file:///Users/a.kitta/dev/git/arduino-ide/electron-app/lib/bundle.js:57068:28)

Moved to #1842

[kittaakos]

Another unhandled use-case for sketch deletion:

• Open IDE2,
• Create a new sketch,
• Click on the ... on the tab toolbar, select Delete, click OK in the dialog, and see the notification for a subsecond

- Nothing happens, no errors. - Deletion of temp sketches should be disabled, or the deletion should work.

Moved to #1843

[91volt]

What does the deletion/rename intend to do here? Is it a brute force modification on the remote sketch when the user executes it or is this operation changes the local sketch only then the user has to push the changes to the remote to have the desired delete/rename effect?

We should trigger the API call when the user delete the sketch folder. This is because if we delete the local version only, the user wouldn't have any entry point to trigger the "push" of this deletion to Arduino servers.

Whenever a new file is created or file content changes, the changes are not automatically applied to the remote content but only to the local cache and users have to push the changes manually. Does IDE2 want to provide different behavior for rename/delete and new/update?

I don't see any issue with this behavior, is the same logic we have applied when a user create a new Cloud Sketch from the IDE 2: the API are called directly after the user create the Cloud sketch from IDE 2, he doesn't have to manually push it after creation.

@kittaakos Do you agree?

P.s. I didn't have any chance to discuss it with @ubidefeo yet.

[91volt]

Since the possibility of Renaming/Deleting sketches from IDE 2 Sketchbook poses some issues and cases that needs time to be addressed and implemented (e.g. the user rename or delete a sketch that is currently opened from another IDE 2 workspace instance), as initial phase we are going to implement the rename/delete actions only within the opened sketch, in tabs contextual menu (with main .ino tab selected).

See screenshots attached: