Automatically check for updates only once (#863)

* Automatically check for updates only once

* set windows version to 2019 on CI

Author: Alberto Iannaccone

.github/workflows/build.yml

@@ -23,7 +23,7 @@ jobs:
     strategy:
       matrix:
         config:
-          - os: windows-latest
+          - os: windows-2019
           - os: ubuntu-18.04 # https://github.com/arduino/arduino-ide/issues/259
           - os: macos-latest
     runs-on: ${{ matrix.config.os }}

arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx

@@ -282,7 +282,7 @@ export class ArduinoFrontendContribution
     this.updaterService.init(
       this.arduinoPreferences.get('arduino.ide.updateChannel')
     );
-    this.updater.checkForUpdates().then(async (updateInfo) => {
+    this.updater.checkForUpdates(true).then(async (updateInfo) => {
       if (!updateInfo) return;
       const versionToSkip = await this.localStorageService.getData<string>(
         SKIP_IDE_VERSION

arduino-ide-extension/src/browser/ide-updater/ide-updater-commands.ts

@@ -31,8 +31,8 @@ export class IDEUpdaterCommands implements CommandContribution {
     });
   }
 
-  async checkForUpdates(): Promise<UpdateInfo | void> {
-    return await this.updater.checkForUpdates();
+  async checkForUpdates(initialCheck?: boolean): Promise<UpdateInfo | void> {
+    return await this.updater.checkForUpdates(initialCheck);
   }
 
   async downloadUpdate(): Promise<void> {

arduino-ide-extension/src/common/protocol/ide-updater.ts

@@ -47,7 +47,7 @@ export const IDEUpdaterPath = '/services/ide-updater';
 export const IDEUpdater = Symbol('IDEUpdater');
 export interface IDEUpdater extends JsonRpcServer<IDEUpdaterClient> {
   init(channel: UpdateChannel): void;
-  checkForUpdates(): Promise<UpdateInfo | void>;
+  checkForUpdates(initialCheck?: boolean): Promise<UpdateInfo | void>;
   downloadUpdate(): Promise<void>;
   quitAndInstall(): void;
   stopDownload(): void;

arduino-ide-extension/src/electron-main/ide-updater/ide-updater-impl.ts

@@ -12,12 +12,13 @@ const IDE_DOWNLOAD_BASE_URL = 'https://downloads.arduino.cc/arduino-ide';
 
 @injectable()
 export class IDEUpdaterImpl implements IDEUpdater {
+  private isAlreadyChecked = false;
   private updater = autoUpdater;
   private cancellationToken?: CancellationToken;
   protected theiaFEClient?: IDEUpdaterClient;
   protected clients: Array<IDEUpdaterClient> = [];
 
-  init(channel: UpdateChannel) {
+  init(channel: UpdateChannel): void {
     this.updater.autoDownload = false;
     this.updater.channel = channel;
     this.updater.setFeedURL({
@@ -52,9 +53,16 @@ export class IDEUpdaterImpl implements IDEUpdater {
     if (client) this.clients.push(client);
   }
 
-  async checkForUpdates(): Promise<UpdateInfo | void> {
-    const { updateInfo, cancellationToken } =
-      await this.updater.checkForUpdates();
+  async checkForUpdates(initialCheck?: boolean): Promise<UpdateInfo | void> {
+    if (initialCheck) {
+      if (this.isAlreadyChecked) return Promise.resolve();
+      this.isAlreadyChecked = true;
+    }
+
+    const {
+      updateInfo,
+      cancellationToken,
+    } = await this.updater.checkForUpdates();
 
     this.cancellationToken = cancellationToken;
     if (this.updater.currentVersion.compare(updateInfo.version) === -1) {