add encoded commands contribution

Author: Alberto Iannaccone

arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts

@@ -302,6 +302,7 @@ import { CoreErrorHandler } from './contributions/core-error-handler';
 import { CompilerErrors } from './contributions/compiler-errors';
 import { WidgetManager } from './theia/core/widget-manager';
 import { WidgetManager as TheiaWidgetManager } from '@theia/core/lib/browser/widget-manager';
+import { EncodedCommandsContribution } from './widgets/sketchbook/encoded-commands-contribution';
 
 MonacoThemingService.register({
   id: 'arduino-theme',
@@ -698,6 +699,7 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {
   Contribution.configure(bind, PlotterFrontendContribution);
   Contribution.configure(bind, Format);
   Contribution.configure(bind, CompilerErrors);
+  Contribution.configure(bind, EncodedCommandsContribution);
 
   // Disabled the quick-pick customization from Theia when multiple formatters are available.
   // Use the default VS Code behavior, and pick the first one. In the IDE2, clang-format has `exclusive` selectors.

arduino-ide-extension/src/browser/widgets/sketchbook/encoded-commands-contribution.ts

@@ -0,0 +1,23 @@
+import { Command, CommandRegistry, MaybePromise } from '@theia/core';
+import { inject, injectable } from '@theia/core/shared/inversify';
+import { Contribution } from '../../contributions/contribution';
+
+@injectable()
+export class EncodedCommandsContribution extends Contribution {
+  @inject(CommandRegistry)
+  protected readonly commandRegistry: CommandRegistry;
+
+  override onReady(): MaybePromise<void> {
+    const params = new URLSearchParams(window.location.search);
+    const encoded = params.get('commands');
+    if (!encoded) return;
+
+    const commands = JSON.parse(decodeURIComponent(encoded));
+
+    if (Array.isArray(commands)) {
+      commands.forEach((c: Command) => {
+        this.commandRegistry.executeCommand(c.id);
+      });
+    }
+  }
+}

arduino-ide-extension/src/browser/widgets/sketchbook/sketchbook-widget-contribution.ts

@@ -1,6 +1,6 @@
 import * as remote from '@theia/core/electron-shared/@electron/remote';
 import { inject, injectable } from '@theia/core/shared/inversify';
-import { Command, CommandRegistry } from '@theia/core/lib/common/command';
+import { CommandRegistry } from '@theia/core/lib/common/command';
 import { MenuModelRegistry } from '@theia/core/lib/common/menu';
 import { PreferenceService } from '@theia/core/lib/browser/preferences/preference-service';
 import { AbstractViewContribution } from '@theia/core/lib/browser/shell/view-contribution';
@@ -29,7 +29,6 @@ import {
 } from '../../../common/protocol/sketches-service-client-impl';
 import { FileService } from '@theia/filesystem/lib/browser/file-service';
 import { URI } from '../../contributions/contribution';
-import { FrontendApplicationStateService } from '@theia/core/lib/browser/frontend-application-state';
 import { EditorManager } from '@theia/editor/lib/browser';
 import { SketchControl } from '../../contributions/sketch-control';
 import { CloudSketchbookCommands } from '../cloud-sketchbook/cloud-sketchbook-contributions';
@@ -71,12 +70,6 @@ export class SketchbookWidgetContribution
   @inject(FileService)
   protected readonly fileService: FileService;
 
-  @inject(CommandRegistry)
-  protected readonly commandRegistry: CommandRegistry;
-
-  @inject(FrontendApplicationStateService)
-  private readonly app: FrontendApplicationStateService;
-
   @inject(EditorManager)
   protected readonly editorManager: EditorManager;
 
@@ -108,12 +101,6 @@ export class SketchbookWidgetContribution
         this.mainMenuManager.update();
       }
     });
-
-    this.app.reachedState('ready').then(() => this.onReady());
-  }
-
-  onReady(): void {
-    this.runEncodedCommands();
   }
 
   async initializeLayout(): Promise<void> {
@@ -272,18 +259,4 @@ export class SketchbookWidgetContribution
         }
       });
   }
-
-  protected runEncodedCommands(): void {
-    const params = new URLSearchParams(window.location.search);
-    const encoded = params.get('commands');
-    if (!encoded) return;
-
-    const commands = JSON.parse(decodeURIComponent(encoded));
-
-    if (Array.isArray(commands)) {
-      commands.forEach((c: Command) => {
-        this.commandRegistry.executeCommand(c.id);
-      });
-    }
-  }
 }