Skip to content

Remove magic numbers from Tone() examples #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove magic numbers from Tone() examples #64

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d5f1af
Update toneMelody.ino
krekr Jun 22, 2023
569885b
Update toneKeyboard.ino
krekr Jun 22, 2023
d751d0b
Update tonePitchFollower.ino
krekr Jun 22, 2023
af1d7e4
Update toneMultiple.ino
krekr Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update toneMelody.ino
  • Loading branch information
@krekr
krekr authored Jun 22, 2023
commit 5d5f1aff09587c3b9fc78dd7de603e8e2e2c0cc8
6 changes: 4 additions & 2 deletions examples/02.Digital/toneMelody/toneMelody.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

#include "pitches.h"

int buzzerPin = 8;

// notes in the melody:
int melody[] = {
NOTE_C4, NOTE_G3, NOTE_G3, NOTE_A3, NOTE_G3, 0, NOTE_B3, NOTE_C4
Expand All @@ -34,14 +36,14 @@ void setup() {
// to calculate the note duration, take one second divided by the note type.
//e.g. quarter note = 1000 / 4, eighth note = 1000/8, etc.
int noteDuration = 1000 / noteDurations[thisNote];
tone(8, melody[thisNote], noteDuration);
tone(buzzerPin, melody[thisNote], noteDuration);

// to distinguish the notes, set a minimum time between them.
// the note's duration + 30% seems to work well:
int pauseBetweenNotes = noteDuration * 1.30;
delay(pauseBetweenNotes);
// stop the tone playing:
noTone(8);
noTone(buzzerPin);
}
}

Expand Down