- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 432
          Suppress compile summary stats if --quiet flag is set on compile.
          #2820
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d6ded91    to
    0c2d093      
    Compare
  
    | Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a dedicated integration test that assert this new behaviour?
If not I'm afraid that we should add one, especially in the case -q and -v is provided.
29a623a    to
    924bbb8      
    Compare
  
    924bbb8    to
    c9122eb      
    Compare
  
    Because it has a better error message than the cobra-provided one: Can't use the following flags together: --quiet, --verbose Instead of: Error: if any flags in the group [quiet verbose] are set none of the others can be; [quiet verbose] were all set
| 
 I've added the tests and they helped me to finally spot where the infamous  | 
| Also tested on my machine (linux) works 🥳 | 
| Is there an option to get the old behaviour (quiet compilation, but library list at the end) back? The only difference between "no argument" and "-q" is that "-q" also suppresses the message | 
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
--quietflag is specified and the compile has no errors.--verboseor--quietflags have been provided.-qshortcut to the--quietflagarduino-cli compilearduino-cli compile -varduino-cli compile -qWhat is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fix #2796
Fix #2510