Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid gRPC TaskProgress message on compile #2731

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 14, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes invalid gRPC TaskProgress message sent on compile, particularly a spurious message with a percentage of completion >100% and a duplicate boolean field completed set to true.

What is the current behavior?

The following message sequence is observed in compile:

[...]
COMPILE PROGRESS> percent:62.96297
COMPILE PROGRESS> percent:66.66667
COMPILE PROGRESS> percent:70.37038
COMPILE PROGRESS> percent:74.07408
COMPILE PROGRESS> percent:77.77779
COMPILE PROGRESS> percent:81.48149
COMPILE PROGRESS> percent:85.185196
COMPILE PROGRESS> percent:88.8889
COMPILE PROGRESS> percent:92.592606
COMPILE PROGRESS> percent:96.29631
COMPILE PROGRESS> completed:true percent:100.000015
COMPILE PROGRESS> completed:true percent:103.70372

There is a last spurious message due to incorrect progress tracking.

What is the new behavior?

[...]
COMPILE PROGRESS> percent:76
COMPILE PROGRESS> percent:80
COMPILE PROGRESS> percent:84
COMPILE PROGRESS> percent:88
COMPILE PROGRESS> percent:92
COMPILE PROGRESS> percent:96
COMPILE PROGRESS> completed:true  percent:100

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fixes #2711

@cmaglie cmaglie self-assigned this Oct 14, 2024
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.67%. Comparing base (ea09108) to head (5b63bfa).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2731      +/-   ##
==========================================
- Coverage   67.68%   67.67%   -0.01%     
==========================================
  Files         234      234              
  Lines       22285    22295      +10     
==========================================
+ Hits        15083    15089       +6     
- Misses       6017     6020       +3     
- Partials     1185     1186       +1     
Flag Coverage Δ
unit 67.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@cmaglie cmaglie merged commit d2cd387 into arduino:master Oct 14, 2024
101 checks passed
@cmaglie cmaglie deleted the task_progress_fix branch October 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clients receive completed: true twice when compiling with the grpc interface
2 participants