Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting legacy tests to new integration-test infra (part 4...) #2315

Merged
merged 19 commits into from
Sep 15, 2023

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.37% ⚠️

Comparison is base (9c073c1) 63.66% compared to head (1a6d693) 63.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2315      +/-   ##
==========================================
- Coverage   63.66%   63.29%   -0.37%     
==========================================
  Files         204      202       -2     
  Lines       19735    19204     -531     
==========================================
- Hits        12564    12156     -408     
+ Misses       6082     6017      -65     
+ Partials     1089     1031      -58     
Flag Coverage Δ
unit 63.29% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
legacy/builder/builder.go 90.90% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini self-assigned this Sep 14, 2023
@alessio-perugini alessio-perugini added the topic: code Related to content of the project itself label Sep 14, 2023
@alessio-perugini alessio-perugini marked this pull request as ready for review September 14, 2023 10:14
@alessio-perugini alessio-perugini changed the title [skip-changelog] Porting legacy tests to new integration-test infra (part4) Porting legacy tests to new integration-test infra (part 4...) Sep 15, 2023
@alessio-perugini alessio-perugini changed the title Porting legacy tests to new integration-test infra (part 4...) Porting legacy tests to new integration-test infra (part 4...) Sep 15, 2023
Base automatically changed from refactor_legacy_part5 to master September 15, 2023 16:04
@cmaglie cmaglie merged commit 6d57ce6 into master Sep 15, 2023
183 checks passed
@cmaglie cmaglie deleted the refactor_legacy_test_part4 branch September 15, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants