Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text output: removed trailing spaces for right-padding of tables #2290

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 1, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Remove the right-padding of tables of the CLI.

What is the current behavior?

See #2289:

Here is an example of what the current behavior looks like, with = replacing spaces to make it clearer.

Sketch=uses=58120=bytes=(11%)=of=program=storage=space.=Maximum=is=507904=bytes.

Used=library===============Version=Path==================================================
CAN=Adafruit=Fork==========1.2.1===/home/trb/Arduino/libraries/arduino-CAN-master========
LibPrintf==================1.2.13==/home/trb/Arduino/libraries/LibPrintf=================
Adafruit=SleepyDog=Library=1.6.4===/home/trb/Arduino/libraries/Adafruit_SleepyDog_Library

What is the new behavior?

No trailing spaces.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #2289

@cmaglie cmaglie self-assigned this Sep 1, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: CLI Related to the command line interface labels Sep 1, 2023
@cmaglie cmaglie added this to the Arduino CLI 0.35.0 milestone Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (3f9373a) 63.40% compared to head (5614168) 63.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2290      +/-   ##
==========================================
- Coverage   63.40%   63.34%   -0.06%     
==========================================
  Files         219      219              
  Lines       19536    19537       +1     
==========================================
- Hits        12386    12375      -11     
- Misses       6069     6078       +9     
- Partials     1081     1084       +3     
Flag Coverage Δ
unit 63.34% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
table/table.go 90.65% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 74547f3 into arduino:master Sep 4, 2023
89 checks passed
@cmaglie cmaglie deleted the no_table_right_padding branch September 4, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change compile so that it prints diagnostic output without trailing spaces
3 participants