Skip to content

[breaking] Do not prevent CLI startup if inventory.yaml is corrupted #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[breaking] Do not prevent CLI startup if inventory.yaml is corrupted #2232

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0224bd7
Made `inventory` package private.
cmaglie Jun 26, 2023
e0df289
If an error occurs reading the inventory.xml just log it and replace it.
cmaglie Jun 26, 2023
c86aa78
Added integration test
cmaglie Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added integration test
  • Loading branch information
@cmaglie
cmaglie committed Jun 26, 2023
commit c86aa783d9bb3dacd50455dba290539bd9384e7c
18 changes: 18 additions & 0 deletions internal/integrationtest/board/board_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,3 +589,21 @@ func TestBoardListWithFailedBuiltinInstallation(t *testing.T) {
require.Empty(t, stderr)
require.Contains(t, string(stdout), "Downloading missing tool builtin:serial-discovery")
}

func TestCLIStartupWithCorruptedInventory(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

_, _, err := cli.Run("core", "update-index")
require.NoError(t, err)

f, err := cli.DataDir().Join("inventory.yaml").Append()
require.NoError(t, err)
_, err = f.WriteString(`data: '[{"name":"WCH;32?'","fqbn":"esp32:esp32:esp32s3camlcd"}]'`)
require.NoError(t, err)

// the CLI should not be able to load inventory and report it to the logs
_, stderr, err := cli.Run("core", "update-index", "-v")
require.NoError(t, err)
require.Contains(t, string(stderr), "Error loading inventory store")
}